Fixed False array value used in XenResource_ModerationQueueHandler_Update

xf_phantom

Well-known member
Method XenResource_ModerationQueueHandler_Update::getVisibleModerationQueueEntriesForUser

The second foreach (line 26) is using $updates AS $updates instead of $updates AS $update


It won't throw an error because $update is defined while the first foreach
Rich (BB code):
foreach ($updates AS $updates)
{
if (!isset($resources[$update['resource_id']]))
{
continue;
}
 

Mike

XenForo developer
Staff member
Cheers D, have fixed.

Why did PHPStorm not complain about that?! :)
 

xf_phantom

Well-known member
Just yellow "maybe this is wrong", I need the red! ;)
You should define your own rules..:D
Most of them are useless so i ignore them but there are also IMO many of the yellow ones which are worth to be red
But they only rock in combination with php code sniffer (and php mess)
 

Attachments

Top