1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed False array value used in XenResource_ModerationQueueHandler_Update

Discussion in 'Resource Manager Resolved Bugs' started by xf_phantom, Mar 26, 2013.

  1. xf_phantom

    xf_phantom Well-Known Member

    Method XenResource_ModerationQueueHandler_Update::getVisibleModerationQueueEntriesForUser

    The second foreach (line 26) is using $updates AS $updates instead of $updates AS $update


    It won't throw an error because $update is defined while the first foreach
    Code:
    foreach ($updates AS $updates)
    {
    if (!isset($resources[$update['resource_id']]))
    {
    continue;
    }
    
     
  2. Mike

    Mike XenForo Developer Staff Member

    Cheers D, have fixed.

    Why did PHPStorm not complain about that?! :)
     
  3. xf_phantom

    xf_phantom Well-Known Member

    it did!
     
  4. Mike

    Mike XenForo Developer Staff Member

    Just yellow "maybe this is wrong", I need the red! ;)
     
  5. xf_phantom

    xf_phantom Well-Known Member

    there's also another complain which you should check (haven't tested it)
     

    Attached Files:

  6. xf_phantom

    xf_phantom Well-Known Member

    You should define your own rules..:D
    Most of them are useless so i ignore them but there are also IMO many of the yellow ones which are worth to be red
    But they only rock in combination with php code sniffer (and php mess)
     

    Attached Files:

    Mike likes this.
  7. Alluidh

    Alluidh Well-Known Member

    @Mike
    Is this fixed in the packages now or should it be fixed by hand?
     
  8. Mike

    Mike XenForo Developer Staff Member

    Fixed by hand.
     

Share This Page