Fixed Error when uninstalling old deactivated 1.x add-ons

[Kevin]

Affected version

2.1

{Yes, I searched to see if anybody else reported this one. No, I didn't find it. If there is another thread out there it's not obvious it's the same issue.}

I'm working with a test site that was an old 1.x site with a lot of add-ons and upgraded to 2.1, originally B2 now running B4. The old 1.x add-ons all show, as expected, on the add-ons page as deactivated. When I go uninstall them though I get an error of page not found.

Here's a random example...

When uninstalling an add-on it starts off with http://{XXX}.com/{XXX}/{XXX}/{XXX}/admin.php?add-ons/BestPosts/uninstall. After selecting I get the 'Confirm' modal and continue. I then get the usual 'processing' display. When finished it returns me back to the ACP but displaying an error message that the page could not be found. The URL left in the browser bar is http://{XXX}.com/{XXX}/{XXX}/{XXX}/admin.php?add-ons/BestPosts/finalize&t=1544035129%2C6a2cdcc64dbe2d832ce50e642bacd449&a=uninstall.

 

[Ozzy47]

Is the addon actually uninstalled though?

 

[Mike]

If it got to the finalize step, it would be uninstalled. Nothing to really worry about here, though it is a bug. It's just that the XF1 add-on case isn't handled here. (An XF2 add-on would still have the files in place and thus wouldn't error.)

I believe this issue is in 2.0 as well, though likely only from point when we added post-uninstall support.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.0.12).

Change log:

Make add-on action finalization more robust when uninstalling legacy add-ons.

Any changes made as a result of this issue being resolved may not be rolled out here until later.