1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Awaiting Feedback Error parsing links in quotes

Discussion in 'Resolved Bug Reports' started by psTubble27, Feb 23, 2012.

  1. psTubble27

    psTubble27 Well-Known Member

    If a quoted post has a URL as the last element in it, the [/ quote] will be included as part of the link.
    See the second post for confirmation.
    http://www.xenforo.com.
     
  2. psTubble27

    psTubble27 Well-Known Member

    Proof.
     
  3. Brogan

    Brogan XenForo Moderator Staff Member

    That looks fine to me.

    post.png
     
  4. psTubble27

    psTubble27 Well-Known Member

    I was still getting the condition to appear :)


    Here is how to break the Quote structure:
    1. In the OP, click Reply
    2. Press Enter on your keyboard (to make room for your text).

    This is where the defect appears. The WYSIWYG editor converts 'http://www.xenforo.com.[/quote]' into a link.
     
  5. psTubble27

    psTubble27 Well-Known Member

    Updated.
     
  6. Mike

    Mike XenForo Developer Staff Member

    Everything looks fine here. What browser? If it's IE, can you confirm it after submitting?
     
  7. psTubble27

    psTubble27 Well-Known Member

    It seems to be an IE9 issue. I've checked it with Firefox 10 and the problem doesn't exist there.

    1) First of all, FF adds a new-line after the quoted passage, so that your cursor is not next to the link+[/quote].

    2) Secondly, even if I bring the cursor up to link+[/quote] and press Enter, it doesn't convert that into a URL.
     
  8. Mike

    Mike XenForo Developer Staff Member

    Can you confirm this happens after submission though?
     
  9. Mr Lucky

    Mr Lucky Well-Known Member

    I am getting this issue also
     
  10. Mr Lucky

    Mr Lucky Well-Known Member

    BTW, I am getting this with v 1.4.2

    Have tested with all addons disabled, still get the problem. I have now raised a ticket

    Everything looks fine if check the edit box for the post, but not when you view page source, part of the closing tag is appended:

    Code:
    "http://howarth.uk.com/wo/manuals/2014saxmouthpiece2ndhand.htm[/QUOTE"
     
  11. Brogan

    Brogan XenForo Moderator Staff Member

    I have responded to your ticket.

    I am unable to reproduce it on your site using Chrome or IE.
     
  12. Mr Lucky

    Mr Lucky Well-Known Member

    Even with the example links?
     
  13. Mike

    Mike XenForo Developer Staff Member

    We would need steps to make it happen. Seeing it after the fact could just be down to something the user did specifically (or a specific browser behavior that can't be disabled, which IE does have in this case)
     
  14. Mr Lucky

    Mr Lucky Well-Known Member

    It seems what is happening is a URL like this:

    Code:
    [URL]http://example.com[/URL]
    gets quoted and becomes this:

    Code:
    [URL='http://example.com[/QUOTE']http://example.com[/URL]
    So if I edit the quote in the reply to take out
    Code:
    [/QUOTE
    So it becomes

    Code:
    [URL='http://example.com']http://example.com[/URL]
    Then save it, all seems to be good again. In fact in the quote whjen I look at again without rich text it shows correctly as

    Code:
    [URL]http://example.com[/URL]
    So my question now is, would it be safe to do a find and replace all instances of

    Code:
    [/QUOTE']
    and replace with

    Code:
    ']
    ??
     
  15. Brogan

    Brogan XenForo Moderator Staff Member

    If you are sure those are the only instances of that, yes you could do a simple query to replace them all.
     
  16. Mr Lucky

    Mr Lucky Well-Known Member

    Thanks. So am I right in thinking there is no legitimate instance of
    Code:
    [/QUOTE']
    I'd be worried that if there was I might break something.
     
  17. Brogan

    Brogan XenForo Moderator Staff Member

    No, that is not a valid closing tag.
     
  18. Mr Lucky

    Mr Lucky Well-Known Member

    Is there a reason why when you just paste a URL in, some would be

    Code:
    [URL]http://example.com[/URL]
    and others are like this

    Code:
    [URL='http://example.com']http://example.com[/URL]
     
  19. Karelke

    Karelke Active Member

    I have had the same issue two months ago but I was unable to reproduce it again. It happens very rarely.
     
  20. Mr Lucky

    Mr Lucky Well-Known Member

    I will keep an eye out now. I had about 50, which i have fixed them using the search and replace I mentioned above.
     

Share This Page