Fixed Error during build doesn't remove _build directory.

[Liam W]

Affected version

2.0

When trying to build a release, an error occurred.

The _build directory was not removed, perhaps it should always be removed?

Liam

 

[Chris D]

What was the error, exactly?

I can only really see one obvious error that didn't clean up the directory.

 

[Liam W]

What was the error, exactly?

I can only really see one obvious error that didn't clean up the directory.

It was a guzzle exception due to me not having an internet connection when I tried to build (I was the tube).

Liam

 

[Chris D]

Arguably, part of the actual bug is that we don't catch that exception and return a more reasonable error message.

 

[Liam W]

Arguably, part of the actual bug is that we don't catch that exception and return a more reasonable error message.

I was about to say that. Might be worth printing a warning saying that minification won’t happen without an internet connection.

Liam

 

[Chris D]

We're just handling that exception a little differently now, and returning a more friendly error, and at the same time deleting the build directory in that case.