ElasticSearch Essentials

ElasticSearch Essentials [Paid] 3.15.12

No permission to buy ($30.00)
After upgrade to XenForo 2.2.10 seeing in Server error log every couple of hours:
Code:
TypeError: Argument 1 passed to XF\Search\Search::getResultSet() must be of the type array, null given, called in /home/forum/src/XF/Pub/Controller/Search.php on line 156 src/XF/Search/Search.php:253

Stack trace
#0 src/XF/Pub/Controller/Search.php(156): XF\Search\Search->getResultSet(NULL)
#1 src/addons/SV/ElasticSearchEssentials/XF/Pub/Controller/Search.php(454): XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#2 src/XF/Mvc/Dispatcher.php(352): SV\ElasticSearchEssentials\XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Results', Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#4 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#5 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(2353): XF\Mvc\Dispatcher->run()
#7 src/XF.php(524): XF\App->run()
#8 index.php(20): XF::runApp('XF\\Pub\\App')
#9 {main}

Request state
array(4) {
  ["url"] => string(14) "/search/503324"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["/search/503324"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
Code:
ErrorException: [E_NOTICE] Trying to get property 'search_results' of non-object src/XF/Pub/Controller/Search.php:156

Stack trace
#0 src/XF/Pub/Controller/Search.php(156): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/forum/...', 156, Array)
#1 src/addons/SV/ElasticSearchEssentials/XF/Pub/Controller/Search.php(454): XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#2 src/XF/Mvc/Dispatcher.php(352): SV\ElasticSearchEssentials\XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Results', Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#4 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#5 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(2353): XF\Mvc\Dispatcher->run()
#7 src/XF.php(524): XF\App->run()
#8 index.php(20): XF::runApp('XF\\Pub\\App')
#9 {main}

Request state
array(4) {
  ["url"] => string(14) "/search/503324"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["/search/503324"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
Code:
ErrorException: [E_NOTICE] Trying to get property 'result_count' of non-object src/XF/Pub/Controller/Search.php:153

Stack trace
#0 src/XF/Pub/Controller/Search.php(153): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/forum/...', 153, Array)
#1 src/addons/SV/ElasticSearchEssentials/XF/Pub/Controller/Search.php(454): XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#2 src/XF/Mvc/Dispatcher.php(352): SV\ElasticSearchEssentials\XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Results', Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#4 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#5 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(2353): XF\Mvc\Dispatcher->run()
#7 src/XF.php(524): XF\App->run()
#8 index.php(20): XF::runApp('XF\\Pub\\App')
#9 {main}

Request state
array(4) {
  ["url"] => string(14) "/search/503324"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["/search/503324"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
Not sure is this related to the latest XenForo or this add-on.
This looks to be a XenForo 2.2.10 bug
 
Errors galore here, too.

Code:
ErrorException: [E_WARNING] Attempt to read property "result_count" on null src/XF/Pub/Controller/Search.php:153
Generated by: Unknown account 15 Jul 2022 at 06:42

Stack trace

#0 src/XF/Pub/Controller/Search.php(153): XF::handlePhpError(2, '[E_WARNING] Att...', '/home/xxx/d...', 153)
#1 src/addons/SV/ElasticSearchEssentials/XF/Pub/Controller/Search.php(454): XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#2 src/XF/Mvc/Dispatcher.php(352): SV\ElasticSearchEssentials\XF\Pub\Controller\Search->actionResults(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Results', Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#4 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\ElasticSearchEssentials\XF\Pub\Controller\Search), Object(XF\Mvc\Reply\Reroute))
#5 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(2353): XF\Mvc\Dispatcher->run()
#7 src/XF.php(524): XF\App->run()
#8 index.php(20): XF::runApp('XF\\Pub\\App')
#9 {main}

Request state

array(4) {
  ["url"] => string(15) "/search/112133/"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}


Edit: Sorry, this has already been reported here.
 
Last edited:
@Xon Server error log:

Code:
Error: Error rendering widget: Call to a member function isIgnored() on int src/addons/XFES/Widget/SimilarThreads.php:113

Generated by: Unknown account Aug 27, 2022 at 8:49 PM

Stack trace

#0 src/addons/SV/ElasticSearchEssentials/XFES/Widget/SimilarThreads.php(30): XFES\Widget\SimilarThreads->render()
#1 internal_data/code_cache/widgets/_75_xfes_thread_view_below_quick_reply_similar_threads.php(5): SV\ElasticSearchEssentials\XFES\Widget\SimilarThreads->render()
#2 src/XF/Template/Templater.php(7653): XF\SubContainer\Widget->{closure}(Object(MaZ\AMP\XF\Template\XF22\Templater), Array, Array)
#3 src/XF/SubContainer/Widget.php(168): XF\Template\Templater->renderWidgetClosure(Object(Closure), Array)
#4 src/XF/Template/Templater.php(1936): XF\SubContainer\Widget->getCompiledWidget(Array, Array)
#5 internal_data/code_cache/templates/l1/s6/public/thread_view.php(1258): XF\Template\Templater->widgetPosition('thread_view_bel...', Array)
#6 src/XF/Template/Templater.php(1651): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\XF22\Templater), Array, Object(XF\Template\ExtensionSet))
#7 src/addons/MaZ/AMP/XF/Template/XF22/Templater.php(52): XF\Template\Templater->renderTemplate('thread_view', Array, true, NULL)
#8 src/XF/Template/Template.php(24): MaZ\AMP\XF\Template\XF22\Templater->renderTemplate('public:thread_v...', Array)
#9 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#10 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#11 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#14 src/XF/App.php(2353): XF\Mvc\Dispatcher->run()
#15 src/XF.php(524): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}

Request state

array(4) {
  ["url"] => string(15) "/threads/90005/"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
 
@Xon Server error log:

Code:
Error: Error rendering widget: Call to a member function isIgnored() on int src/addons/XFES/Widget/SimilarThreads.php:113

Generated by: Unknown account Aug 27, 2022 at 8:49 PM

Stack trace

#0 src/addons/SV/ElasticSearchEssentials/XFES/Widget/SimilarThreads.php(30): XFES\Widget\SimilarThreads->render()
#1 internal_data/code_cache/widgets/_75_xfes_thread_view_below_quick_reply_similar_threads.php(5): SV\ElasticSearchEssentials\XFES\Widget\SimilarThreads->render()
#2 src/XF/Template/Templater.php(7653): XF\SubContainer\Widget->{closure}(Object(MaZ\AMP\XF\Template\XF22\Templater), Array, Array)
#3 src/XF/SubContainer/Widget.php(168): XF\Template\Templater->renderWidgetClosure(Object(Closure), Array)
#4 src/XF/Template/Templater.php(1936): XF\SubContainer\Widget->getCompiledWidget(Array, Array)
#5 internal_data/code_cache/templates/l1/s6/public/thread_view.php(1258): XF\Template\Templater->widgetPosition('thread_view_bel...', Array)
#6 src/XF/Template/Templater.php(1651): XF\Template\Templater->{closure}(Object(MaZ\AMP\XF\Template\XF22\Templater), Array, Object(XF\Template\ExtensionSet))
#7 src/addons/MaZ/AMP/XF/Template/XF22/Templater.php(52): XF\Template\Templater->renderTemplate('thread_view', Array, true, NULL)
#8 src/XF/Template/Template.php(24): MaZ\AMP\XF\Template\XF22\Templater->renderTemplate('public:thread_v...', Array)
#9 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#10 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#11 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#14 src/XF/App.php(2353): XF\Mvc\Dispatcher->run()
#15 src/XF.php(524): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}

Request state

array(4) {
  ["url"] => string(15) "/threads/90005/"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
Does this occur when ElasticSearch Essentials is disabled?

This error is coming fairly deep inside the unmodified XFES similar threads functionality, and appears unrelated to my add-on(s).
 
Xon updated ElasticSearch Essentials with a new update entry:

3.10.0 - Feature update

  • Require php 7.2+
  • Fix that elasticsearch could be queried for impossible queries when searching taggable/groupable's which aren't possible
  • Fix XFES similar thread would cause an extra query when "Replace Enhanced Search 2.2's suggest threads implementation" was disabled.
  • Add autocomplete support for NixFifty's Tickets add-on (v2.4.0+)
  • Add 'most recent' search sort type support for Tickets
  • Support content tooltips from autocomplete

Read the rest of this update entry...
 
Xon updated ElasticSearch Essentials with a new update entry:

3.11.0 - Feature & Bugfix update

  • Fix unexpected additional queries from ESE similar thread widget
  • Fix v3.10.x regression where similar threads performance was made worse and would ignore the "limit similar thread results by" option
  • Fix disabling "Replace Enhanced Search 2.2's suggest threads implementation" option wasn't being fully respected
  • Implement "Same forum boost amount" option from XFES with ESE similar threads
  • Add "Push specific content type permission checks into global autocomplete"...

Read the rest of this update entry...
 
Hi @Xon,

If I disable "search_form_macros – Rework date" in template modifications, does it have any effect on the add-on functionality?

It just changes the mobile view in advanced search results from XF default.

XF Default:
<dl>
<dt>newer than></dt>
<dd>field</dd>
</dl>
<dl>
<dt>olderthan></dt>
<dd>field</dd>
</dl>

With Rework date enabled:
<dl>
<dt>newer than></dt>
<dd>field older than field</dd>
</dl>
 
Xon updated ElasticSearch Essentials with a new update entry:

3.11.2 - Bugfix/Minor feature update

  • Workaround for XF bug where search results are fetched more than once
  • Fix "Call to undefined method canViewSimilarContents()" during add-on upgrade
  • Implement MySQL-base caching for similar thread results, as otherwise ElasticSearch may be overloaded by uncached queries
    • Redis/Memcache-based caching is still strongly recommended.
  • Improve autocomplete & similar thread performance for forums with large number of nodes by avoiding fetching the entire...

Read the rest of this update entry...
 
Xon updated ElasticSearch Essentials with a new update entry:

3.11.5 - Security update

Users who had thier licence expire since the last update and this update, have had a licence expension applied.

  • Fix not removing 3rd party content types a user can't search from general search, resulting in search result pages showing less results than expected, which cam be used as an oracle to determine if a phrase exists.
  • Fix possible case where 'recent content' tab could leak posts from forums which users did not have 'view threads by others' permission due to incomplete...

Read the rest of this update entry...
 
After upgrading to ElasticSearch Essentials 3.11.6 (from version 3.10.2) -- and I already installed Search Improvements 2.6.2 and Standard Library 1.13.0 -- I had the following error appear three times. Also the normal error to rebuild the search cache. The error only appeared three times and the search function seems to be working fine. But I thought I would make you aware of it.

This is the very latest version of XenForo, 2.2.11.

Server error log
  • ErrorException: Fatal Error: Class SV\ElasticSearchEssentials\XF\Search\Data\Thread contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (SV\ElasticSearchEssentials\XF\Search\Data\Thread::getSearchableTreeForSimilarContent) src/addons/SV/ElasticSearchEssentials/XF/Search/Data/Thread.php:26
  • Generated by: Unknown account
  • Oct 13, 2022 at 8:05 AM

Stack trace​

#0 [internal function]: XF::handleFatalError()
#1 {main}

Request state​

array(4) {
["url"] => string(54) "/forums/threads/560sec-amg-clone-tribute-project.2606/"
["referrer"] => bool(false)
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}
 
After upgrading to ElasticSearch Essentials 3.11.6 (from version 3.10.2) -- and I already installed Search Improvements 2.6.2 and Standard Library 1.13.0 -- I had the following error appear three times. Also the normal error to rebuild the search cache. The error only appeared three times and the search function seems to be working fine. But I thought I would make you aware of it.

This is the very latest version of XenForo, 2.2.11.

Server error log
  • ErrorException: Fatal Error: Class SV\ElasticSearchEssentials\XF\Search\Data\Thread contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (SV\ElasticSearchEssentials\XF\Search\Data\Thread::getSearchableTreeForSimilarContent) src/addons/SV/ElasticSearchEssentials/XF/Search/Data/Thread.php:26
  • Generated by: Unknown account
  • Oct 13, 2022 at 8:05 AM

Stack trace​

#0 [internal function]: XF::handleFatalError()
#1 {main}

Request state​

array(4) {
["url"] => string(54) "/forums/threads/560sec-amg-clone-tribute-project.2606/"
["referrer"] => bool(false)
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}
This can happen when uploading the files and search triggers half-way through before the files are consistent.

Let me know if it keeps happening.
 
This can happen when uploading the files and search triggers half-way through before the files are consistent.

Let me know if it keeps happening.
Hi @Xon,

What you say is what I assumed becuase the errors didn't reappear, and haven't reappeared since the upgrade. So I think everything is fine.

Thanks
Gerry
 
  • Like
Reactions: Xon
Getting used to this add-on and have some feedback related to autocomplete in search (desktop). I've never seen an autocomplete use a close X on the top right and I think it shouldn't be there. No other site have I seen the use of this. People should just ignore suggestions, if all else, allow ESC to close the list. Also it's important that the font and styling is the same as the input box for search. I'm not sure if a different font is being used for the drop down autocomplete list. My main feedback and concern is the close X on the upper right corner and making the drop down list more subtle.

I'm not overly thrilled with the results yet, I'm exploring both relevance and most recent. Right now autocomplete is turned off on my site as the built in search system is nice.
 
Top Bottom