Duplicate Editing reactions causes errors

[Sim]

Affected version

2.1.5a

After upgrading to XF 2.1.5a, any edits made to reactions in the admin area (including disabling / enabling them) causes server errors to be logged.

Server error log
ErrorException: [E_NOTICE] Undefined index: steps src/XF/Job/AbstractRebuildJob.php:28
Generated by: Simon Nov 14, 2019 at 4:03 AM
Stack trace
#0 src/XF/Job/AbstractRebuildJob.php(28): XF::handlePhpError(8, '[E_NOTICE] Unde...', 'sr...', 28, Array)
#1 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#2 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#3 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#4 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#5 src/XF/Mvc/Dispatcher.php(350): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(261): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#7 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#8 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#10 src/XF.php(391): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(48) "http://xft.local/admin.php?reactions/love.2/edit"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(5) {
    ["only_id"] => string(2) "16"
    ["_xfRequestUri"] => string(32) "/admin.php?reactions/love.2/edit"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

Server error log
ErrorException: [E_NOTICE] Undefined index: start src/XF/Job/AbstractRebuildJob.php:30
Generated by: Simon Nov 14, 2019 at 4:03 AM
Stack trace
#0 src/XF/Job/AbstractRebuildJob.php(30): XF::handlePhpError(8, '[E_NOTICE] Unde...', 'sr...', 30, Array)
#1 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#2 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#3 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#4 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#5 src/XF/Mvc/Dispatcher.php(350): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(261): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#7 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#8 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#10 src/XF.php(391): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(48) "http://xft.local/admin.php?reactions/love.2/edit"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(5) {
    ["only_id"] => string(2) "16"
    ["_xfRequestUri"] => string(32) "/admin.php?reactions/love.2/edit"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

Server error log
ErrorException: [E_NOTICE] Undefined index: batch src/XF/Job/AbstractRebuildJob.php:30
Generated by: Simon Nov 14, 2019 at 4:03 AM
Stack trace
#0 src/XF/Job/AbstractRebuildJob.php(30): XF::handlePhpError(8, '[E_NOTICE] Unde...', 'sr...', 30, Array)
#1 src/XF/Job/Manager.php(253): XF\Job\AbstractRebuildJob->run(G)
#2 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#3 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#4 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#5 src/XF/Mvc/Dispatcher.php(350): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(261): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#7 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#8 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#10 src/XF.php(391): XF\App->run()
#11 admin.php(13): XF::runApp('XF\\Admin\\App')
#12 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(48) "http://xft.local/admin.php?reactions/love.2/edit"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(5) {
    ["only_id"] => string(2) "16"
    ["_xfRequestUri"] => string(32) "/admin.php?reactions/love.2/edit"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["_xfResponseType"] => string(4) "json"
  }
}

First tested on a brand new installation of XF 2.1.4 - no issues found. Subsequently upgraded to XF 2.1.5a, and then the issues began, so pretty sure it is 2.1.5a specific.

 

[Azaly]

It probably same as https://xenforo.com/community/threads/rebuild-reaction-score-server-error.171989/post-1384024

 

[Chris D]

It is.