[DigitalPoint] App for Cloudflare® 1.9.8.1

[NealC]

@digitalpoint I just turned on presigned URL's to test it out again as I had some issues with it early on. All seem to work fine. What's odd though is I'm using one of @AndyB xf2add-ons.com Open PDF add-on in XF 2.3.7 which works well to open a PDF in the browser, however, with presigned URL's enabled your cloudflare add-on it downloads the PDF's instead of opening for viewing. Any ideas?

Open PDF

Description: Opens PDF attachments in the browser. By default Safari will download PDF attachments instead of viewing them in the browser. This add-on will allow Safari users to simply click on the PDF attachment and the document will open in...

www.xf2addons.com

 

[digitalpoint]

@digitalpoint I just turned on presigned URL's to test it out again as I had some issues with it early on. All seem to work fine. What's odd though is I'm using one of @AndyB xf2add-ons.com Open PDF add-on in XF 2.3.7 which works well to open a PDF in the browser, however, with presigned URL's enabled your cloudflare add-on it downloads the PDF's instead of opening for viewing. Any ideas?

Open PDF

Description: Opens PDF attachments in the browser. By default Safari will download PDF attachments instead of viewing them in the browser. This add-on will allow Safari users to simply click on the PDF attachment and the document will open in...

www.xf2addons.com

Well, I don't know anything abut that addon, but it's super simple to tell a browser to display rather than download, by simply adding the Content-Disposition: inline HTTP header. I'm guessing they are doing it a different way though, because this addon is already picking up the Content-Disposition header that XenForo adds, and then relays that to the presigned URL request. The cleanest way to alter content disposition would be to extend the standard \XF\Http\Request::isInlineDisplaySafe() method XenForo uses to do determine if the attachment is inlineable or not.

TL;DR: The Content-Disposition header that XenForo assigns to attachments is already being relayed... so best to just extend the XenForo method if you want to make changes to it.