Defer JS [Deleted]

[Harpers Tate]

Just in case it matters, I saw this using Waterfox 35, but not using IE 11.

 

[Jeremy P]

Could we revisit this please, @Jeremy P ?
It happens on these pages.
https://www.avforums.com/forums/movie-forum.37/
https://www.avforums.com/forums/tv-show-forum.55/
It seems to be a compatibility problem with @Snog 's two TMDB addons.
Any ideas?
Thanks

Have you tried adding scripts related to those add-ons to the blacklist? If they require jQuery or anything else they should be blacklisted too.

I don't have access to those add-ons so I can't say for sure.

 

[Stuart Wright]

Thanks, Jeremy. I don't think those addons have any scripts. I'll deal with it, though, thanks.

 

[kaieivindm]

I assume that since my notices at the top dissapeared with this add-on, I have to blacklist them right? So it skips it?

Edit:

My UAT site is 1.4.6 and the notices are still showing as it should.

Live site is 1.4.5 and notices are gone.

 

[Jeremy P]

@kaieivindm The built-in XenForo notices? Those should be unaffected.

 

[kaieivindm]

@Jeremy P yes, default ones. Any tips to what I can check? Strange thing is that it's fine with 1.4.6, but not showing with 1.4.5.

 

[Jeremy P]

I could check it out if you provide a link.

 

[kaieivindm]

@Jeremy P my site is www.spillforumet.no

Update:

1) I had to delete all notices, and re-add them - they now show
2) Page criteria does not work now, so if I want the notice to show on all forumnodes, besides 2-3, it wont show at all. If I dont use that criteria, it shows as intended.
3) If I choose not to use page criteria, the notice show as normal

 

[Jeremy P]

@kaieivindm I can't reproduce, there's not really any way this add-on could cause that.

Notices are enhanced by JS but not displayed with it. Notices are in the plain HTML source.

Even if I disable JS entirely at the browser level, notices with page criteria still appear fine on my site (they just don't slide or transition).

 

[Frode789]

Gonna have to try this one! Though I have a lot of JS scripts, so I fear it may break something.

 

[Jeremy P]

If you disable the add-on, it will stop making any changes.. so it shouldn't be too worrisome to try out unless you can't afford to (potentially) break your site momentarily.

In my experience, most things usually work fine with JS deferred, but YMMV. Just remember if anything does need to be blacklisted, then you will have to blacklist its dependencies too (jQuery is a common dependency, for example).

 

[Frode789]

If you disable the add-on, it will stop making any changes.. so it shouldn't be too worrisome to try out unless you can't afford to (potentially) break your site momentarily.

Ok thanks. Did give it a go, great performance boost! Sadly my ads are messed up:

 

[Jeremy P]

Ads are the one common exception to deferring JS. Adsense is blacklisted by default, but others would have to be blacklisted manually.

If you blacklist your ads in the options then it should be fine.

 

[kaieivindm]

@kaieivindm I can't reproduce, there's not really any way this add-on could cause that.

Notices are enhanced by JS but not displayed with it. Notices are in the plain HTML source.

Even if I disable JS entirely at the browser level, notices with page criteria still appear fine on my site (they just don't slide or transition).

I agree with you, it should not be affected by this add-on at all. I did upgrade my live site with 1.4.6 as my UAT was working just fine with this add-on and the notices. But there is something with the live site that I just can't get to work.

But the cause should not be this add-on, thanks for the replies.

 

[murat çabuk]

hi all

when i active the defer js plugin, reply box not shown

what can i do for it ?

 

[Jeremy P]

hi all

when i active the defer js plugin, reply box not shown

what can i do for it ?

Check the JS console for any errors.

 

[BobbyWibowo]

Thanks a lot! Works properly with my own inline JS/CSS minify add-on after tweaking the execution order of my add-on a bit. Also the blacklist system was so straightforward that I had no trouble at all to exclude IE conditionals.

EDIT: I ended up merging Deferred.php into my own personal add-on. I hope you don't mind, right? I left all the comments untouched and only edited the code a bit. Besides it's personal add-on though. I just want to avoid any possible conflicts.

 

[Jeremy P]

@BobbyWibowo Glad to hear

Definitely don't mind at all! The add-on is released under the MIT license, which permits derivative works so long as the copyright notices are kept.

 

[BobbyWibowo]

@Jeremy P Thanks again!

 

[rafass]

Hello Jeremy, thanks for share this great mod!
Besides install the addon, I have to do something more?
In my case never defer the scrips, the report of GTmetrix always show the same: