Defer JS [Deleted]

[Carla Birch]

@maxicep @TBDragon @Carla Birch can anyone confirm the update properly addresses the issue? It works on my test setup, but my live site is still on 1.1 with an older version of this addon.

Thanks for your issue reports and patience in getting them fixed. Hopefully this is the last update for awhile. I will update the PHP 5.3 version once I can confirm the latest version doesn't have any issues.

Updated and all seems to be work fine with the stock xenforo editor, but my personal problem is i use the added TinyMCE Quattro and that still gives the error.
http://xenforo.com/community/resources/tinymce-quattro-and-its-wysiwyg-bbcodes.1881/

 

[Jeremy P]

Updated and all seems to be work fine with the stock xenforo editor, but my personal problem is i use the added TinyMCE Quattro and that still gives the error.
http://xenforo.com/community/resources/tinymce-quattro-and-its-wysiwyg-bbcodes.1881/

Pushing out a patch that works with TinyMCE too.. give me 5 25? minutes, I have to recompile PHP locally. Turns out that takes forever.

 

[Jeremy P]

Jeremy P updated Defer JS with a new update entry:

TinyMCE Support

This release supports the 2.0.1d fix for TinyMCE editors.

As such, this probably supports XenForo 1.0 and 1.1 now, but I haven't tested it with those versions. If you use this with those versions, let me know if it works. Still requires PHP 5.4.

PHP 5.3 update coming eventually.

Read the rest of this update entry...

 

[Slind]

Jeremy P updated Defer JS with a new update entry:

TinyMCE Support



Read the rest of this update entry...

Hm, what was the issue with TinyMCE? I haven't see one.

 

[Jeremy P]

Hm, what was the issue with TinyMCE? I haven't see one.

Google Chrome > Edit Post > More Options = Chrome refuses to load CSS with deferred WYSIWYG editors on POST requests.

 

[Carla Birch]

Jeremy P updated Defer JS with a new update entry:

TinyMCE Support



Read the rest of this update entry...

All working here now thanks

 

[Puremin0rez]

I'm getting this problem on my forum - whenever I first load the page in Chrome (clean restart), this occurs: http://i.imgur.com/4QOaf4f.png

If I refresh the page, and for the remainder of my chromes session, it looks how it should like this: http://i.imgur.com/JXtXLyQ.png

 

[Jeremy P]

@Puremin0rez That would be to do with a custom style or add-on. I can take a look if you tell me which one it is.

 

[Puremin0rez]

@Puremin0rez That would be to do with a custom style or add-on. I can take a look if you tell me which one it is.

I am using the Flexile theme.

 

[Jeremy P]

I am using the Flexile theme.

I'm going to go ahead and say this is an incompatibility between Flexile and this addon.

There's nothing I can really do with this addon to prevent things like that. Unfortunately, deferring javascript simply doesn't work for some setups or situations.

In those cases, the only solution is to not defer anything.. in which case the addon should just be disabled. Sorry.

 

[Nigel Lew]

Worked great. I did this and a few other things and my project is coming along nicely.

Quick question. I seem to have a bit too much white space in my markup now. Is there a way to resolve that or should I leave it alone? Sorta being picky. I am hitting almost 90 on Google Page Speed so I can live with it if need be.

Thanks for the mod. It made a bigger difference than I would have initially thought.

Nigel

 

[Jeremy P]

Worked great. I did this and a few other things and my project is coming along nicely.

Quick question. I seem to have a bit too much white space in my markup now. Is there a way to resolve that or should I leave it alone? Sorta being picky. I am hitting almost 90 on Google Page Speed so I can live with it if need be.

Hmm. The addon should replace the script tags without white space, but any white space surrounding them will remain. A greedier regex seems to take care of that, I'm just not sure if it's worth adding because there's a lot of whitespace in XenForo markup to begin with. I thought about adding the option to minify HTML but it's a heavy operation so I think any performance improvements would be offset by processing time.

If you want to try replacing line 69 of library/Jrahmy/DeferJs/Deferrer.php with:

'/\s*?<script.*?>.*?<\/script>\s*?/is',

.. and line 107 with:

$this->deferred .= trim($matches[0]);

..but the only proper "solution" is HTML minification which just doesn't seem worth it.

 

[Nigel Lew]

Hey, thanks for the quick response. I could not quite wrap my head around the regex to do that. I will let you know how it goes.

I am not a huge fan of minifying much of anything either.

thanks again!
Nigel

 

[Jeremy P]

I've included the regex above Minifying HTML isn't terrible in production it just requires slow preprocessing that negates any performance benefits. Not worth the bump in pagespeed points. Page Speed is nice for getting tips, but a perfect score shouldn't be sought over imo.

 

[Nigel Lew]

Yep, I caught the code thanks. I may have misspoke. And I agree. I am an seo guy. I cant help myself sometimes. Its plenty fast as it is. Its just something that crossed my mind so I figured I would ask.

Thanks again. I can swap that code shortly . I am doing 3 things at once today. Tad hectic around here.

N.

 

[Jeremy P]

Jeremy P updated Defer JS with a new update entry:

(Hopefully) Final Release; PHP 5.3.0 Update

Barring unforeseen problems, this is the last update this addon will receive in a long time.

The (unsupported) PHP 5.3 version available from the FAQ has been updated to match the latest PHP 5.4 version.

Let me know if there are any further questions or problems.

Thanks for using this addon!

Read the rest of this update entry...

 

[Daniel-SP]

Thanks for the addon, Jeremy.

A question: By checking my code and seeing that the <script> tag is right before the </body>, I can assume that It worked great without any issue, right?

 

[surfsup]

When I was installing the XML file, it made my entire site go to a blank page even backend. I had to remove the directory via ftp in order to get the site back live. I am running 1.3

 

[Raydianze]

Bombed out installing on 1.3 !

 

[Jeremy P]

Thanks for the addon, Jeremy.

A question: By checking my code and seeing that the <script> tag is right before the </body>, I can assume that It worked great without any issue, right?

Yeah.

When I was installing the XML file, it made my entire site go to a blank page even backend. I had to remove the directory via ftp in order to get the site back live. I am running 1.3

On PHP 5.4+ ? I can't reproduce at all. Blank pages are usually PHP errors, there was nothing in your XenForo or server error log?

Bombed out installing on 1.3 !

That's not very helpful. What PHP version? What do you mean by "bombed out?"

Error reports should be detailed.