[DCom] Auto Merge Double Post 2.4.2

[Ashley S]

Have you configured user group permissions?

View attachment 320161

Is that settings it should be on? Thanks.

 

[PixelOrange]

Is that settings it should be on? Thanks.

Did you ever get this to work? Also on 2.3.6 and I cannot get posts to merge. I have the time limit set and it's set to "No". I tried "Yes" as well thinking the grammar was just incorrect but that doesn't seem to have done it either.

 

[DimmmCom]

Did you ever get this to work? Also on 2.3.6 and I cannot get posts to merge. I have the time limit set and it's set to "No". I tried "Yes" as well thinking the grammar was just incorrect but that doesn't seem to have done it either.

After refreshing the page, are the posts merged? If not, then I can only assume that you have incorrectly configured the system of user group rights. You can try to set such settings for checking.

 

[PixelOrange]

After refreshing the page, are the posts merged? If not, then I can only assume that you have incorrectly configured the system of user group rights. You can try to set such settings for checking.
View attachment 321196

I had set it for 60 minutes and No. I'll try setting it for unlimited and never and see if that works but when I inspected permissions it said it was set to 60 minutes and No from all groups. I'll take screenshots when I try it next.

 

[DimmmCom]

I had set it for 60 minutes and No. I'll try setting it for unlimited and never and see if that works but when I inspected permissions it said it was set to 60 minutes and No from all groups. I'll take screenshots when I try it next.

After refreshing the page, are the posts merged?

 

[flowman]

Bug Report: Auto-Merge fails when messageMaxLength is set to 0
Affected Version: 2.3.1

Issue:
When the messageMaxLength option is set to 0 (no limit) the auto-merge feature is currently prevented from executing.

File:
ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/Thread.php, Line 96

Suggested Fix:
Modify the conditional check to ensure it only runs when a maximum length is actually set > 0

-- if (mb_strlen($message) > $options->messageMaxLength)
++ if ($options->messageMaxLength > 0 && mb_strlen($message) > $options->messageMaxLength)

 

[Kirby]

Bug Report: Auto-Merge fails when messageMaxLength is set to 0
Affected Version: 2.3.1

Issue:
When the messageMaxLength option is set to 0 (no limit) the auto-merge feature is currently prevented from executing.

Is there any plan (yet) to fix this issue?

 

[DimmmCom]

Is there any plan (yet) to fix this issue?

Hi. I'll update today.

 

[DimmmCom]

DimmmCom updated [DCom] Auto Merge Double Post with a new update entry:

2.4.0

• Fixed a bug where messages would not merge when the message length limit was disabled.
• Fixed a bug in the regular expression where merging of quoted messages was prohibited.
• Added a check to ensure that the "[automerge]" tag contains nothing but a timestamp.
• Added handling of the maximum number of attachments in a message.
• Code refactoring.

Read the rest of this update entry...

 

[BarisY]

Hi,

Even though the plugin settings are configured as shown in the first screenshot I provided, it’s not merging the messages. What would you suggest we do?

The relevant permissions are only assigned to the registered users group; no additional permissions have been set for any other groups.

 

[Recep Baltaş]

@DimmmCom Do you plan to help us? And BTW, why do I have to install a 3rd party add-on for this basic feature? @Chris D

 

[DimmmCom]

Hi,

Even though the plugin settings are configured as shown in the first screenshot I provided, it’s not merging the messages. What would you suggest we do?

The relevant permissions are only assigned to the registered users group; no additional permissions have been set for any other groups.

View attachment 335930

View attachment 335929

Hi. Send me the forum address and test account information in a private message. I'll take a look.

 

[DimmmCom]

DimmmCom updated [DCom] Auto Merge Double Post with a new update entry:

2.4.1

• Fixed a bug where messages would not be merged if the number of attachments was set to 0 (unlimited).

Read the rest of this update entry...

 

[lumicolca93]

DimmmCom updated [DCom] Auto Merge Double Post with a new update entry:

2.4.1



Read the rest of this update entry...

Please help. I have one problem:
Error: Class "ThemeHouse\AutoMergeDoublePost\XF\Pub\Controller\XFCP_Post" not found in src/addons/ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/PostController.php at line 7

1. include() in src/vendor/composer/ClassLoader.php at line 576
2. Composer\Autoload\{closure}() in src/vendor/composer/ClassLoader.php at line 427
3. Composer\Autoload\ClassLoader->loadClass()
4. spl_autoload_call() in src/XF.php at line 410
5. XF::createAliasForClass()
6. class_exists() in src/XF/Extension.php at line 213
7. XF\Extension->extendClass() in src/XF/App.php at line 3389
8. XF\App->extendClass() in src/XF/App.php at line 1854
9. XF\App->XF\{closure}() in src/XF/Container.php at line 250
10. XF\Container->create() in src/XF/App.php at line 3340
11. XF\App->controller() in src/XF/Mvc/Dispatcher.php at line 303
12. XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 266
13. XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
14. XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
15. XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2830
16. XF\App->run() in src/XF.php at line 850
17. XF::runApp() in index.php at line 23

 

[otto]

Same Error here after Update from Xenforo 2.3.11 to 2.3.12

• Error: Class "ThemeHouse\AutoMergeDoublePost\XF\Pub\Controller\XFCP_Post" not found
• src/addons/ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/PostController.php:7

#0 src/vendor/composer/ClassLoader.php(576): include()
#1 src/vendor/composer/ClassLoader.php(427): Composer\Autoload\{closure}('/var/www/vhosts...')
#2 [internal function]: Composer\Autoload\ClassLoader->loadClass('ThemeHouse\\Auto...')
#3 src/XF.php(410): spl_autoload_call('ThemeHouse\\Auto...')
#4 [internal function]: XF::createAliasForClass('ThemeHouse\\Auto...')
#5 src/XF/Extension.php(213): class_exists('ThemeHouse\\Auto...')
#6 src/XF/App.php(3389): XF\Extension->extendClass('XF\\Pub\\Controll...', NULL)
#7 src/XF/App.php(1854): XF\App->extendClass('XF\\Pub\\Controll...')
#8 src/XF/Container.php(250): XF\App->XF\{closure}('XF\\Pub\\Controll...', Array, Object(XF\Container))
#9 src/XF/App.php(3340): XF\Container->create('controller', 'XF:Post', Array)
#10 src/XF/Mvc/Dispatcher.php(303): XF\App->controller('XF:Post', Object(XF\Http\Request))
#11 src/XF/Mvc/Dispatcher.php(266): XF\Mvc\Dispatcher->dispatchClass('XF:Post', 'edit', Object(XF\Mvc\RouteMatch), NULL, NULL)
#12 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), NULL, NULL)
#13 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#14 src/XF/App.php(2830): XF\Mvc\Dispatcher->run()
#15 src/XF.php(850): XF\App->run()
#16 index.php(23): XF::runApp('XF\\Pub\\App')
#17 {main}

array(4) {
  ["url"] => string(200) "/beitraege/130744/bearbeiten?_xfResponseType=json&_xfWithData=1&_xfRequestUri=%2Fthemen%2Fneues-und-anpassungen-im-forum-kurz-informiert.16274%2F&_xfToken=1784968226%2C9acaf82c4e50ce8e0433a8b2a040f467"
  ["referrer"] => string(95) "https://forum-ddr-landmaschinen.de/themen/neues-und-anpassungen-im-forum-kurz-informiert.16274/"
  ["_GET"] => array(4) {
    ["_xfResponseType"] => string(4) "json"
    ["_xfWithData"] => string(1) "1"
    ["_xfRequestUri"] => string(61) "/themen/neues-und-anpassungen-im-forum-kurz-informiert.16274/"
    ["_xfToken"] => string(43) "1784968226,9acaf82c4e50ce8e0433a8b2a040f467"
  }
  ["_POST"] => array(0) {
  }
}

With activated Addon, post edit wont work anymore - have to deactivate the add-on to use edit funktion again.

My Solution:
I deinstalled the add-on from Dcom now and installed the original also free add-on from OzzModz.
Yes, its the older one but this works with xenforo 2.3.12 without errors for me after certain tests:

[OzzModz] Auto Merge Double Posts

Nov 2, 2021

Automatically merge double posts

• Painbaker
• Add-ons [2.x]

 

[rogerl]

Hopefully @DimmmCom will be along with an official fix soon, but if you edit

src/addons/ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/PostController.php

and change the line

class PostController extends XFCP_Post

to

class PostController extends XFCP_PostController

that should stop the error - see the post from @Chris D at https://xenforo.com/community/threads/addon-errors-after-xf-cloud-updated-to-2-3-11.239085/ which explains why this happens.

Obviously if you patch above you will get a warning that the addon file has been modified, so you may prefer to wait for a proper release.

 

[Astra]

It seems the author is either unaware of the issue or has stopped supporting the app. A post about the error was also made on their forum, but there’s been nothing but silence.

 

[tenis]

After update from Xenforo 2.3.11 to 2.3.12 I also receive these errors.

• Error: Class "ThemeHouse\AutoMergeDoublePost\XF\Pub\Controller\XFCP_Post" not found
• src/addons/ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/PostController.php:7

I installed Ozzy's old addon and it works:

Thread '[OzzModz] Auto Merge Double Posts'

Nov 2, 2021

Ozzy47 submitted a new resource:

[OzzModz] Auto Merge Double Posts - Automatically merge double posts

Auto Merge Double Posts
Automatically merge posts from people that haven't yet understood what this dubious edit function is.

Features include:

• Permission-controlled automated double post merger.

Attribution:
Originally coded by ThemeHouse and released as open source.

View attachment 259585

View attachment 259586

View attachment 259587...

Read more about this resource...

• Ozzy47
• Replies: 60
• Forum: Add-on releases [2.x]

• 
• 

 

[BarisY]

Hello @DimmmCom,

Thank you for continuing the development of this add-on based on the original open-source ThemeHouse project. We encountered the following error while running version 2.4.1 on XenForo 2.3.12:

Error: Class "ThemeHouse\AutoMergeDoublePost\XF\Pub\Controller\XFCP_Post" not found
src/addons/ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/PostController.php:7

Since this add-on is important to our community, we created a small Techolay-maintained fork based on your 2.4.1 release for internal use. We retained the original add-on ID, namespace, license, and attribution to both ThemeHouse and DCom. The error appears to be caused by a class-proxy naming mismatch in the following file:

src/addons/ThemeHouse/AutoMergeDoublePost/XF/Pub/Controller/PostController.php

The extension class was renamed to PostController for XenForo 2.3, but it still extends the legacy XFCP_Post proxy:

class PostController extends XFCP_Post

In this configuration, XenForo expects the proxy class matching the renamed extension class: XFCP_PostController.

Changing the declaration to the following resolves the issue:

class PostController extends XFCP_PostController

After applying this change, we tested the add-on successfully on XenForo 2.3.12. Post editing works again, and consecutive replies are merged correctly. Hopefully you can include this one-line fix in the next official release so other users do not encounter the same error.

 

[Astra]

It would be great if the author made changes to the plugin build. If payment is required for this, let me know—I’ll buy it.