Fixed Customized properties display order not updated

[Russ]

Affected version

2.1

I really hope this is a bug... we recently re-ordered some of our custom properties however if a child style has that property customized the display order isn't updated until it's reverted. Maybe relates to how it was approached with this response: https://xenforo.com/community/threa...ported-with-child-styles.158944/#post-1312448

 

[Mike]

It is the same as the other bug you reported (for the same reasons).

I didn't go into the full detail in the other report (as I don't think I remembered all the details at the time), but it's important to note that the behavior there is rather particular to the workflow you listed. Specifically, the fact that the child style is being re-created after the changes to the parent. This causes us to not be able to directly track the dependency information.

If you create a property in the parent, customize it in the child and then edit various properties in the parent (display order, value params, etc), this will be reflected in the child. It's the import part which causes issues.

Is this a common workflow for you (or an issue you've commonly seen with your customers)? I would normally assume that people update the parent style, which would push the changes to any children. It sort of seems specific to having a child export installed on a newer version of the parent.

 

[Steve F]

Is this a common workflow for you

Yes, it’s mainly with custom clients where we import their exported child into a newer version of the framework (on our dev board). We generally don’t want to disturb their live environment trying to fix outdated properties (templates).

 

[Russ]

We’ll often import the new version of the parent on the client site as a new style, export their current child and import under the new for testing purposes.

So it sounds like if we want to do that route... we need to export the current parent and child, import them as new styles THEN upgrade the parent to the new version.

 

[Jeremy P]

A brief 5 years later and I think this should be resolved

https://xenforo.com/community/threads/reverting-property-shows-object-oject.220955/

The above fix causes most fields to be pulled from the parent property, if there is one. This means the corresponding XML fields will effectively be ignored, but presumably that's always the desired behavior. One important caveat is that the XML property value will be validated and cast based on the parent's parameters. For instance, in the unlikely event that the parent is a boolean property but the XML specifies a color property, the value will be converted to a boolean during the import process (or merely reset to the default value in more complicated scenarios).