XF 2.1 Custom bbcode for HR (horizontal line) RESOLVED

[djbaxter]

If I create a custom bbcode called HR with the replacement <hr> it correctly inserts a horizontal line

BUT:

1. any text following the HR is not displayed although I can still see it in edit mode; and
2. Xenforo erroneously "closes" the tag with [/hr] at the end of the post.

This is the settings page:

 

[djbaxter]

Sample when posted:

text
[hr]
text

Sample of source edit after posting:



Note: This happens in both the custom style and the default Xenforo style.

 

[djbaxter]

I meant to post this in Bug reports actually. Please move there if appropriate.

 

[Mr Lucky]

I think this is not a Xenforo bug just a limitation of how bbcode works, if there isn't a closing tag it will make one

For it to work you have to have a closing bbcode when you post or else it gets added after the text.

This will work.

Text here
[hr][/hr]
More text here

Obviously users probably won't know that it therefore makes most sense if you have a text editor icon for the bbcode which will automatically enter opening and closing tags,

 

[djbaxter]

Unfortunately, that still doesn't work for me.

Source:

text

[HR][/HR]

text

Posted:

text



text

 

[djbaxter]

Found this:

W3Schools.com

W3Schools offers free online tutorials, references and exercises in all the major languages of the web. Covering popular subjects like HTML, CSS, JavaScript, Python, SQL, Java, and many, many more.

www.w3schools.com

Differences Between HTML 4.01 and HTML5

In HTML5, the <hr> tag defines a thematic break.

In HTML 4.01, the <hr> tag represents a horizontal rule.

However, the <hr> tag may still be displayed as a horizontal rule in visual browsers, but is now defined in semantic terms, rather than presentational terms.

All the layout attributes are removed in HTML5. Use CSS instead.

 

[djbaxter]

Resolved:

 

[Mr Lucky]

Not sure what that means, or why it's not working for you.

See here:

test horizontal rule

Text above line text below line

cafesaxophone.com

 

[Mr Lucky]

Resolved:

View attachment 202097

Aha, that does explain, mine had that sorry I hadn't thought to look in Advanced. I must have done that by trial and error then forgotten.

Glad it works now.

 

[djbaxter]

I also tidied up the display a bit by changing the HTML replacement to

<br /><hr>

Now



Displays as

 

[Mr Lucky]

Also of course you can style the hr any way you like extra.less if you give it a class in the bbcode

 

[Mr Lucky]

One annoying thing about this is that if you invoke the bbcode via an icon in the text editor, the cursor will be there blinking between the [hr] and the [/hr] so tempting your users to put the next text there as opposed to after the [/hr]

I doubt this is a xenforo issue though. In fact I found the solution above from a phpbb support posts. (Sorry again about missing the advanced html parameter!)