Fixed Conversations & message limits

[Xon]

Conversation messages appear to not implement the following limits:

• Maximum message length.
• Maximum image count.
• Maximum media count.

Especially the maximum message length is critical to ensuring bbcode rendering performance stays consistent by preventing stupidly long messages.

 

[Amaury]

I can't test the third one as we don't have that, but I am unable to reproduce the first two:

 

[Xon]

I can't test the third one as we don't have that, but I am unable to reproduce the first two:

View attachment 132556 View attachment 132557

That is enforced when you post with RTE, if you post in bbcode editor mode you bypass it.

 

[Amaury]

That wasn't mentioned in your post.

Confirmed, though.

 

[Mike]

This is fixed now, thanks. I'm surprised it took this long to come up.

This also has a component of a fix in XFMG as well, as we extend the image check to cover the gallery BB code as well (though that only applies if you have XFMG).

 

[Xon]

This is fixed now, thanks. I'm surprised it took this long to come up.

I only noticed when writing this add-on which uses XF code to implement the hard work of count [img] tags for posts and wondered where the code was for conversations.