XF 2.1 Change to user_searcher_orders callback signature?

[Jake B.]

It seems that at some point there was a change to the callback signature for user_searcher_orders, does anyone happen to know when exactly this change happened?

Previously it seems that it was \XF\Searcher\User $userSearcher, array &$sortOrders, but now it seems to be `\XF\Searcher\User $userSearcher, array &$sortOrders, array &$stringSortOrders I can't find anything documented on this change anywhere here either

 

[Chris D]

It was changed in XF 2.1.2:

Fixed - Error when creating member statistic using relational field

I added Profile.location to userSearcherOrders and it works fine unless I set it to show the value, in which case I get the following. TypeError: Argument 2 passed to XF\Service\MemberStat\Preparer::prepareCacheResults() must be of the type array, object given, called in...

xenforo.com

 

[Jake B.]

It was changed in XF 2.1.2:

Fixed - Error when creating member statistic using relational field

I added Profile.location to userSearcherOrders and it works fine unless I set it to show the value, in which case I get the following. TypeError: Argument 2 passed to XF\Service\MemberStat\Preparer::prepareCacheResults() must be of the type array, object given, called in...

xenforo.com

Ah, cool thanks. I'd imagine it'd be safe to default to an empty array in the function definition since it's not used in earlier versions for backwards compatibility then?