Change date [Paid] 3.4
- Thread starter AndyB
- Start date
Hello Andy, I have been using your ChangeDate add-on for a very, very long time. Unfortunately, there were some nasty problems in the past because thread->first_post_id was not set correctly or not always correctly.
The result was that some threads appeared to be sorted correctly, but thread->first_post_id was often set to post #2 or #n instead of post #1.
And of course, if you then unknowingly delete post #2 and don't pay attention to the warning, you might end up deleting entire threads. This happened to me a couple of dozen times until I realized something was wrong.
I then added two additional finders in your add-on to fetch the first and last posts in the thread, and used them to update the thread. Of course, there are simpler ways to do it, but maybe not the way you try?
Also, there's no need to recalculate the post_counter since the number of posts does not change when moving them around.
Another topic is the timezone; I'm not sure if it works as intended in your add-on when the server and visitor timezones are different, or if the user is actually not in $visitor->timezone. Maybe you could take another look at this.
Otherwise, many thanks for the great add-on; it has served me very well for years. Today, it's going into retirement after I'm done testing my version.
Best regards
The result was that some threads appeared to be sorted correctly, but thread->first_post_id was often set to post #2 or #n instead of post #1.
And of course, if you then unknowingly delete post #2 and don't pay attention to the warning, you might end up deleting entire threads. This happened to me a couple of dozen times until I realized something was wrong.
I then added two additional finders in your add-on to fetch the first and last posts in the thread, and used them to update the thread. Of course, there are simpler ways to do it, but maybe not the way you try?
Also, there's no need to recalculate the post_counter since the number of posts does not change when moving them around.
Another topic is the timezone; I'm not sure if it works as intended in your add-on when the server and visitor timezones are different, or if the user is actually not in $visitor->timezone. Maybe you could take another look at this.
Otherwise, many thanks for the great add-on; it has served me very well for years. Today, it's going into retirement after I'm done testing my version.
Best regards
Last edited:
AndyB
Well-known member
AndyB updated Change date with a new update entry:
See description
Read the rest of this update entry...
See description
Read the rest of this update entry...
