Call to a member function X on a non-object

[Chris D]

Given this code:

    public static function controllerPreDispatch(XenForo_Controller $controller, $action)
    {
        self::$controllerName = $controller->getRouteMatch()->getControllerName();
    }

Which when executed by the Tapatalk mobile app, produces this error:

ErrorException: Fatal Error: Call to a member function getControllerName() on a non-object - library/AVForums/Banners/Listener.php:288

Does the following seem like a reasonable solution?

    public static function controllerPreDispatch(XenForo_Controller $controller, $action)
    {
        try
        {
            if (is_object($controller) && $controller instanceof XenForo_Controller)
            {
                self::$controllerName = $controller->getRouteMatch()->getControllerName();
            }
        }
        catch (Exception $e)
        {
            self::$controllerName = '';
        }
    }

Because, it doesn't work

Regardless of what conditionals I wrap around this line:

self::$controllerName = $controller->getRouteMatch()->getControllerName();

Tapatalk always throws this error:

ErrorException: Fatal Error: Call to a member function getControllerName() on a non-object - library/AVForums/Banners/Listener.php:288

Normal forum operation is fine. It's only a problem when we access the forum via the Tapatalk app.

 

[Daniel Hood]

   public static function controllerPreDispatch(XenForo_Controller $controller, $action)
{
try
{
if (is_object($controller) && $controller instanceof XenForo_Controller)
{
$routeMatch = $controller->getRouteMatch();
if (is_object($routeMatch) && $routeMatch instanceof XenForo_RouteMatch)
{
self::$controllerName = $controller->getRouteMatch()->getControllerName();
}
}
}
catch (Exception $e)
{self::$controllerName = '';
}
}

What's that do? Might not be getting a route match.

[edit] Copying your code into the editor looks horrible, sorry.

 

[Chris D]

Awesome Daniel, that looks like it has worked.

Thank you.

 

[Daniel Hood]

No problem. It's odd the routematch isn't there though...?

 

[Chris D]

It's all odd. It's Tapatalk

Thanks again.

 

[Stuart Wright]

@Chris Deeming, we are getting this error again. What do I do to fix it, please?

 

[Chris D]

Just sent you an updated version.

My bad. It seems I didn't merge the changes I made with my local copy.