Won't fix Bug in template hook sidebar_visitor_panel_stats

[DragonByte Tech]

Affected version

1.5.15a

This is the code:

            <div class="stats">
            <xen:hook name="sidebar_visitor_panel_stats">
                <dl class="pairsJustified"><dt>{xen:phrase messages}:</dt> <dd>{xen:number $visitor.message_count}</dd></dl>
                <dl class="pairsJustified"><dt>{xen:phrase likes}:</dt> <dd>{xen:number $visitor.like_count}</dd></dl>
                <xen:if is="{$xenOptions.enableTrophies}">
                    <dl class="pairsJustified"><dt>{xen:phrase points}:</dt> <dd>{xen:number $visitor.trophy_points}</dd></dl>
                </xen:if>
            </div>
            </xen:hook>

As you can see, the closing </xen:hook> contains the closing div, whereas the starting div is outside the hook. It would make much more sense to move the closing div outside the hook, so that any stats added to the end of the hook still get the benefit of the stats class.

On the default skin, this isn't a big deal, but it may be on some custom skins.


Fillip

 

[Mike]

You're not wrong, though at this point, I don't think we're going to change this. It's very likely/possible that template modifications are working around this issue (as it would have been in place for years), so changing this will potentially break BC unnecessarily.