Fixed Broken autolink

[PaulB]

@Chris D, I'm able to repro this locally by making a post with the following content on XF 2.2.13, PHP 8.2:

www.example.com://

\XF\Validator\Url::isValid returns false, which results in url being null. I'm not sure why this isn't triggering on XenForo.com. All versions of PHP >= 8.0 should throw an error under those circumstances (https://3v4l.org/YhJDG), so for some reason that code either isn't running on XenForo.com, or isValid is returning true.

 

[Chris D]

I think this has been fixed and rolled out here. @Jeremy P?

 

[htsumer]

If I add it like this it doesn't get an error

[URL unfurl="true"]https://kesenek.sgk.gov.tr/KesenekWeb/doc/Aylıksız_İzinli_Sayılan_Kamu_Personeli_GSS_Primleri.pdf[/URL]

 

[PaulB]

Here's a quick patch that should mitigate the issue for anyone who's hitting it. It won't fully restore intended functionality, but it's good enough to stop the exceptions.

 

[Jeremy P]

I think this has been fixed and rolled out here. @Jeremy P?

Yes, if anyone can reproduce further issues here do let us know.

I've attached a patch in the meantime. It relaxes strict URL validation in messages as we typically defer to browsers to handle URLs which may not be properly encoded there anyways.

 

[Ivo2]

Yes, if anyone can reproduce further issues here do let us know.

I've attached a patch in the meantime. It relaxes strict URL validation in messages as we typically defer to browsers to handle URLs which may not be properly encoded there anyways.

How can I install the fix?

 

[htsumer]

How can I install the fix?

I'm wondering how to upload this diff file

 

[Paul B]

It isn't uploaded.

You manually edit the files according to the information in the diff.

 

[t0fx]

It isn't uploaded.

You manually edit the files according to the information in the diff.

wich file can i edit to fix this problem ?

 

[Tracy Perry]

wich file can i edit to fix this problem ?

The actual diff file tells you that in it... but you do have to be familiar with how to read the diff file.
I personally think a better solution would have been to post the actual related fixed files themselves as a lot of admins are going to run into the very issues that are being observed after that diff was posted in how to implement the code.

 

[kick]

you can use patch. starting from version 2.7 it supports git format

GNU patch - News: GNU patch version 2.7 released [Savannah]

Savannah is a central point for development, distribution and maintenance of free software, both GNU and non-GNU.

savannah.gnu.org

 

[Tracy Perry]

you can use patch. starting from version 2.7 it supports git format

GNU patch - News: GNU patch version 2.7 released [Savannah]

Savannah is a central point for development, distribution and maintenance of free software, both GNU and non-GNU.

savannah.gnu.org

which works for those with shell access.
for those that don't have it, they are stuck out.

 

[kick]

which works for those with shell access.
for those that don't have it, they are stuck out.

Well, using xenforo hosting is like that for that option, @Brogan answered you

You manually edit the files according to the information in the diff.

 

[Chris D]

Feel free to upload these changed files directly.

We are rolling out the patch to Cloud customers automatically.

 

[Tracy Perry]

Feel free to upload these changed files directly.

Thanks Chris... happy to see this was rolled out like many other file patches have been in the past.

 

[htsumer]

Feel free to upload these changed files directly.

We are rolling out the patch to Cloud customers automatically.

Thank you very much it's fixed

 

[t0fx]

Feel free to upload these changed files directly.

We are rolling out the patch to Cloud customers automatically.

Thank you bro

 

[htsumer]

Is this normal? Is it a problem?

 

[Chris D]

You have uploaded modified files so, yes, it’s normal. No, it’s not a problem.

 

[diskutopia]

Is there any ETA on this fix being implemented in the self-hosted version?