1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed "BBCode Sites" function oddness

Discussion in 'Resolved Bug Reports' started by Belazor, Oct 14, 2010.

  1. Belazor

    Belazor Active Member

    It seems to me that the $cache variable in this function is largely pointless:

    PHP:
        public function getBbCodeMediaSitesForCache()
        {
            
    $sites $this->getAllBbCodeMediaSites();
            
    $cache = array();
            foreach (
    $sites AS &$site)
            {
                
    $cache[$site['media_site_id']] = array(
                    
    'embed_html' => $site['embed_html']
                );
            }

            return 
    $sites;
        }
     
  2. Enigma

    Enigma Well-Known Member

    If I had to guess, it should return $cache instead of $sites so it doesn't cache unnecessary information. ;)
     
  3. Mike

    Mike XenForo Developer Staff Member

    Indeed it should be returning $cache. I can't find anything that uses any data other than embed_html.
     
    Enigma likes this.

Share This Page