Fixed Batch Update Threads: first post reaction score range default incorrect

Affected version
2.1.0

Kevin

Well-known member
OK, maybe not a bug but at least a minor annoyance. :p

Pretty much everywhere else in the ACP when doing a numeric search with a range using "0" as the starting value and "-1" results in a query with no maximum value. Except when dealing with the reactions scores. The default max for "First post reaction score between" is "1" so if you're trying to do a batch update of threads in a selected forum using the default values on the criteria page you'll likely get only a small number of the threads you're looking for.

Changing the "First post reaction score between" max value to "-1" doesn't work and you'll end up with no matching threads at all.

Changing the value to some really higher number like '999999' is needed for getting all threads in the selected forum.

To be consistent, can we get "-1" to be recognized as the max value when doing updates for "First post reaction score between" and have it as the default value? Or at the least change the default value to be the max number? 🤔

197509
 

Brogan

XenForo moderator
Staff member
Reactions scores can be negative so it must be necessary to be able to use negative values.
 

Mike

XenForo developer
Staff member
In this case, what you're explaining is intentional. Unlike the reply count and view count, the reaction score can be negative, so -1 can't really be used as a sentinel value.

However, it looks like it's defaulting to 0 and 1, which is a problem as that then causes a constraint on the results. We'll need to identify a workaround for this.
 

Kevin

Well-known member
Thanks guys, I forgot about possible negative scores since I'm not using Reactions in that manner.

Thanks, Mike, for thinking about a workaround for this one.
 

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.1).

Change log:
Remove the default values for first_post_reaction_score in the Thread searcher, similar to the reaction_score in the User searcher.
Any changes made as a result of this issue being resolved may not be rolled out here until later.
 
Top