Attachment Improvements By Xon 2.6.1

[Xon]

Xon updated Attachment Improvements By Xon with a new update entry:

2.0.7 - Bugfix update

• Correctly set "Allowed Image Attachment File Extensions" type as string not boolean

Read the rest of this update entry...

 

[snoopy5]

Hi Xon,

in the XF 2.1rc ACP I can set as a usergroup permission a maximum file size i.e. to 1MB.

But this blocks the upload of images if it is exceeded.

If I install your addon, can I then set the XF maximum usergroup permisson to a higher level, i.e. 20MB, and still get each upload converted to i.e. 500KB, If I set 500KB in your addon in that forum?

Does this works also for the MediaGallery?

 

[Xon]

Hi Xon,

in the XF 2.1rc ACP I can set as a usergroup permission a maximum file size i.e. to 1MB.

But this blocks the upload of images if it is exceeded.

If I install your addon, can I then set the XF maximum usergroup permisson to a higher level, i.e. 20MB, and still get each upload converted to i.e. 500KB, If I set 500KB in your addon in that forum?

No, it allows uploads to the higher limit. The uploads are not converted in size.

Does this works also for the MediaGallery?

No, I haven't added XFRM or XFMG support.

 

[snoopy5]

The uploads are not converted in size.

Would it be difficult to add this ability to your addon, so that even smaller sizes (in KB) are possible than the standard ACP settings??

 

[demon326]

Could it be that is not working in the final 2.1 release?

• Global limit is set to 1024 kb.
• Default user group is set to 500 kb.
• upload >500 KB image works, even if the usergroup is set to 500kb.
• It reports the image larger then it is: image is 800kb, Xen reports its 1.3 MB...

It looks like it just ignores the limits...

 

[Xon]

• Global limit is set to 1024 kb.
• Default user group is set to 500 kb.
• upload >500 KB image works, even if the usergroup is set to 500kb.

Screenshot the output of the 'analyses permissions' for that user in a given forum, with the size limit expanded. (ie is there another usergroup raising the limit.

It reports the image larger then it is: image is 800kb, Xen reports its 1.3 MB...

This is expected as XenForo transcodes most images.

 

[demon326]

Screenshot the output of the 'analyses permissions' for that user in a given forum, with the size limit expanded. (ie is there another usergroup raising the limit.

I have tested it with two diffrent users and made sure they are not in any other group then the default 'registerd'.

The default registerd user group permission analyse:



The default node permission analyse:


It does not give a error 'to large' when uploading a 800kb file.

I'm testing this on Xamp with php 7.1, no idea if that makes any diffrence

 

[demon326]

Small update: The same issue persists on the live board.

 

[Don Daniello]

Could it be that is not working in the final 2.1 release?

• Global limit is set to 1024 kb.
• Default user group is set to 500 kb.
• upload >500 KB image works, even if the usergroup is set to 500kb.
• It reports the image larger then it is: image is 800kb, Xen reports its 1.3 MB...

It looks like it just ignores the limits...

That's because the code in this addon does nothing to post attachments:

<?php

namespace SV\AttachmentImprovements\XF\Attachment;

class Post extends XFCP_Post
{
    public function getConstraints(array $context)
    {
        $constraints = parent::getConstraints($context);

        $thread = null;
        $nodeId = null;
        $em = \XF::app()->em();

        if (!empty($extraContext['node_id']))
        {
            $nodeId = $extraContext['node_id'];
        }
        else if (!empty($extraContext['thread_id']))
        {
            /** @var \XF\Entity\Thread $thread */
            $thread = $em->find('XF:Thread', $extraContext['thread_id']);
            if ($thread)
            {
                $nodeId = $thread->node_id;
            }
        }
        else if (!empty($extraContext['post_id']))
        {
            /** @var \XF\Entity\Post $post */
            $post = $em->find('XF:Post', $extraContext['post_id']);
            if ($post)
            {
                /** @var \XF\Entity\Thread $thread */
                $thread = $em->find('XF:Thread', $post->thread_id);
                if ($thread)
                {
                    $nodeId = $thread->node_id;
                }
            }
        }

        if ($nodeId)
        {
            $constraints = $this->svUpdateConstraints($constraints, $nodeId, $thread);
        }

        return $constraints;
    }
    ...

$extraContext is not defined. Replace it with $context and it will work.

This is file: src/addons/SV/AttachmentImprovements/XF/Attachment/Post.php

@Xon it's a typo, please fix.

I'd also appreciate a version that allows to only activate additional permissions. I had to edit the addon to disable all the other features.

 

[Xon]

Xon updated Attachment Improvements By Xon with a new update entry:

2.0.8 - Bugfix update

• Fix per-forum attachment permissions not applying

Read the rest of this update entry...

 

[mydevilroot]

Hi,

First of all, thanks a lot for making this extension. I have a problem with it, I can upload svg attachments, however they are not displaying on the full screen and not displaying in post, does not matter if full image or thumbnail. I am using ngxin and did proper config as suggested.
Any help would be appreciated, thank you!

The svg file is available for download after pressing on it, working properly, so it's only about the display.

 

[Xon]

Make sure you have SVG listed as a valid image attachment ("Allowed Image Attachment File Extensions" option). Otherwise open a ticket on my site and share the SVG which isn't working so I can test

 

[Xon]

Xon updated Attachment Improvements By Xon with a new update entry:

2.0.9 - Bugfix update

• Fix "Error: Call to a member function save() on null" when handling Jpeg's without exif information
• Fix compatibility issue with some 3rd party add-ons

Read the rest of this update entry...

 

[SeToY]

Does this allow me to permit higher attachment counts for my staff than my regular users, or does this only allow changes per-forum? That's not quite clear to me from the description.

 

[Xon]

per user-group per forum. So both! (you need to raise the global limit, then restrict regular users down. Same end result)

 

[Xon]

Xon updated Attachment Improvements By Xon with a new update entry:

2.1.0 - Bugfix update & XF version requirement change

• Require XF2.1+, remove XF2.0 support
• Fix "Call to a member function save() on null" when handing an invalid jpeg
• Fix SVG thumbnail support for XF2.1 (for new attachments)

Read the rest of this update entry...

 

[rootksk]

Store attachments in remote server via FTP, Do you have this feature?

 

[Xon]

Nope.

That can be done with via the stock mountable file systems that XenForo supports;

FTP Adapter - Flysystem

Filesystem abstraction library for PHP.

flysystem.thephpleague.com

example of using s3 which should be adaptable;

Using DigitalOcean Spaces or Amazon S3 for file storage in XF 2.1+

XenForo Version Compatibility The download is only compatible with XenForo 2.1 and above. Why this guide? Since XenForo 2.0.0 we have supported remote file storage using an abstracted file system named Flysystem. It's called an abstracted file...

xenforo.com

I haven't done this myself, but this sort of thing is doable with some work

 

[Xon]

Xon updated Attachment Improvements By Xon with a new update entry:

2.2.0 - Feature update

• Fix XFMG support (ie content stored in data rather than internal_data)
• Support for video stream via partial content requests
• Add "Partial content maximum chunk size" option

Read the rest of this update entry...

 

[WxP]

screenshot please?