As part of upgrades, flush redis

[briansol]

Every upgrade, I have to go in to the console and manually go to redis-cli and flushall.
easy enough, but not streamlined.

As part of XF upgrade, if redis is detected, give the user the option to flush all caches before retuning to the admincp (which, they will see they 'site is upgrading' message anyway rendering it useless.

 

[Kirby]

Hmm, we use Redis on all our XenForo 2 instances but I don't remember ever having to manually flush Redis so I wonder why you have to do this?

That being said I wouldn't mind an option to flush caches after an upgrade.

 

[Kirby]

@briansol
Are you using @Xon Redis Cache by any chance?
If so, this might be the reason why you have to flush Redis after a XF upgrade.

 

[Xon]

This sounds like overly aggressive page caching. It probably should be an XF bug as the page cache should use a single 'site is being upgraded' cache key to avoid polluting the cache.

Are you using @Xon Redis Cache by any chance?

My add-on doesn't require flushing during XF instance upgrades or major add-on updates. I've done multiple XF2.1=>XF2.2 and XF2.2=>XF2.3 updates without requiring manual flushing of redis.

 

[bzcomputers]

Every upgrade, I have to go in to the console and manually go to redis-cli and flushall.
easy enough, but not streamlined.

As part of XF upgrade, if redis is detected, give the user the option to flush all caches before retuning to the admincp (which, they will see they 'site is upgrading' message anyway rendering it useless.

As @Xon said, I'm pretty sure this isn't necessary. I've never flushed Redis after any XenForo upgrades (for years on multiple sites) and never noticed any issues. As it is, there isn't a single XenForo Redis TTL longer than 3600 so within 1 hour all keys will automatically be replaced anyway.

 

[briansol]

I am using xon's addon.

100% of the time for the past few years, every upgrade i get stuck with the 'system is being upgraded' message. It goes away in 20 min or so, but a clear of the cache is always the immediate fix.

I'm not using anything else caching-wise, other than some http headers for attachments.