[AP] Style Suite

[AP] Style Suite [Paid] 2.16.10

No permission to buy (€15.00)
Overview Updates (113) Reviews (12) History Discussion
BUG:

- Postbit preview image url calls from /account/data/apathy/StyleSuite/postbits/presets/l/43.jpg
Only when saving and reload will it load the correct url of data/apathy/StyleSuite/postbits/presets/l/43.jpg

BUG:

- postbit style appears on deleted content from admin/mod account

1726332834425.webp

Recommendation:
(easier to see)
1726332588756.webp

#NOTES

It seems to be adding it's own transparency on, which I do not want, after all , opacity should be the one to set that but the sliders seem tempermental. (Maxed opacity in settings produces the following css output)

Code: 
background-image: linear-gradient(to bottom, rgba(0, 0, 0, 0.3), rgba(0, 0, 0, 0.5)), url(/data/apathy/StyleSuite/postbits/presets/l/78.jpg?1726332207);
visual
1726333705991.webp
Whereas it is suppose to look like this!
1726333740004.webp
 
Last edited:
MentaL said:
BUG:

- Postbit preview image url calls from /account/data/apathy/StyleSuite/postbits/presets/l/43.jpg
Only when saving and reload will it load the correct url of data/apathy/StyleSuite/postbits/presets/l/43.jpg
Click to expand...
I wasn't able to reproduce this but I have a (hopeful) fix for the next update

MentaL said:
BUG:

- postbit style appears on deleted content from admin/mod account
Click to expand...
I'm not really certain this is a bug tbh, those are still posts they just have their contents hidden until theyre "expanded"

MentaL said:
Recommendation:
(easier to see)
View attachment 310881
Click to expand...
Is the recommendation here the centered text? I think this would be more suitable for inclusion in an FAQ (which doesn't exist but really should) since this seems more to do with the active style rather than the addon

You could currently achieve this by adding lines like this to your extra.less:
Code: 
.styleSettings--postbit
{
     text-align: center;
}

This would center the text on the postbit style pane.

MentaL said:
#NOTES

It seems to be adding it's own transparency on, which I do not want, after all , opacity should be the one to set that but the sliders seem tempermental. (Maxed opacity in settings produces the following css output)

Code: 
background-image: linear-gradient(to bottom, rgba(0, 0, 0, 0.3), rgba(0, 0, 0, 0.5)), url(/data/apathy/StyleSuite/postbits/presets/l/78.jpg?1726332207);
Click to expand...
To clarify, you're using the "opacity" slider on the style settings page right? This is actually not for controlling the "dim" overlay, but instead the strength of the blur/contrast/brightness filters. Possibly this should be reworded to be made more clear.

There's two style properties that control the "dim" at admin.php?styles/master-style.0/style-properties/group&group=apStyleSuite:
  • Postbit gradient start color
  • Postbit gradient end color
To remove the dim you'd change these values to rgba(0,0,0,0.0), but this of course is a global style-based change that will affect all postbits
 
Another recommendation, mainly to avoid issues with webp and imagick. In this video, I'm using an uploaded animated webp that the server has encoded but it produces a ghosting effect which sucks. A good work around would be to allow remote url embedding for the image as opposed to uploading as I can still host it locally but rather than have Xenforo convert it, it'll just embed it as it is.

Cheers

View attachment WEBP_ISSUE.mp4

apathy said:
I wasn't able to reproduce this but I have a (hopeful) fix for the next update
Click to expand...
i think its being called as folder/file as opposed to /folder/file
apathy said:
Is the recommendation here the centered text? I think this would be more suitable for inclusion in an FAQ (which doesn't exist but really should) since this seems more to do with the active style rather than the addon

You could currently achieve this by adding lines like this to your extra.less:
Click to expand...
No, the issue was the additional block that could moved to the top as opposed to the bottom. Unless, its just a local styling issue.
 
Last edited:
MentaL said:
Another recommendation, mainly to avoid issues with webp and imagick. In this video, I'm using an uploaded animated webp that the server has encoded but it produces a ghosting effect which sucks. A good work around would be to allow remote url embedding for the image as opposed to uploading as I can still host it locally but rather than have Xenforo convert it, it'll just embed it as it is.

Cheers
Click to expand...
I think this should be doable but it wont be in the upcoming update (hoping it'll be out in 1 or 2 days now)

MentaL said:
i think its being called as folder/file as opposed to /folder/file
Click to expand...
I'm hoping this fix will also do a better job of using the correct URL if your forum is stored in a sub-folder like /forum

MentaL said:
No, the issue was the additional block that could moved to the top as opposed to the bottom. Unless, its just a local styling issue.
Click to expand...
OH wow I can't believe I didn't see the difference at first. So I actually do really like how your suggestion looks and it's a smart usage of whats otherwise empty space, but I'm not sure how I could move the other styles' previews there without it looking kinda crappy (tooltip & profile style previews would be the main offenders here).

As it stands, all styles' previews are located at the top above the settings themselves, so until I can figure out how to sanely move the others over there without them looking squashed I'll just leave this as an open suggestion, but it definitely isnt being ruled out either.
 
apathy said:
OH wow I can't believe I didn't see the difference at first. So I actually do really like how your suggestion looks and it's a smart usage of whats otherwise empty space, but I'm not sure how I could move the other styles' previews there without it looking kinda crappy (tooltip & profile style previews would be the main offenders here).
Click to expand...
Maybe via an admin option have two methods, one - condensed (mine) or two, default (yours).

apathy said:
I'm hoping this fix will also do a better job of using the correct URL if your forum is stored in a sub-folder like /forum
Click to expand...

mine is forum.domain.com

'EDIT

another interesting thing;

1726748045628.webp


you cannot view any uploads via the attachment browser. Not too important though.
 
Last edited:
Code: 
[LIST]
[*]TypeError: Extension public:post_macros :: user_cell() error: apathy\StyleSuite\Template\TemplaterSetup::fnPostbitStyle(): Argument #3 ($user) must be of type XF\Entity\User, null given, called in /home/x/public_html/forum.x.com/src/XF/Template/Templater.php on line 1220
[*]src/addons/apathy/StyleSuite/Template/TemplaterSetup.php:70
[*]Generated by: Unknown account
[*]Sep 19, 2024 at 7:20 PM
[/LIST]
[HEADING=2]Stack trace[/HEADING]
#0 src/XF/Template/Templater.php(1220): apathy\StyleSuite\Template\TemplaterSetup::fnPostbitStyle(Object(SV\StandardLib\XF\Template\Templater), true, NULL)
#1 internal_data/code_cache/templates/l1/s10/public/post_macros.php(35): XF\Template\Templater->func('postbitstyle', Array, true)
#2 src/XF/Template/Templater.php(1093): XF\Template\Templater->{closure}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#3 src/XF/Template/Templater.php(1029): XF\Template\Templater->renderExtensionInternal('user_cell', Array, Array, Object(XF\Template\ExtensionSet))
#4 internal_data/code_cache/templates/l1/s10/public/post_macros.php(158): XF\Template\Templater->renderExtension('user_cell', Array, Object(XF\Template\ExtensionSet))
#5 src/XF/Template/Templater.php(1093): XF\Template\Templater->{closure}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#6 src/XF/Template/Templater.php(1029): XF\Template\Templater->renderExtensionInternal('full_body', Array, Array, Object(XF\Template\ExtensionSet))
#7 internal_data/code_cache/templates/l1/s10/public/post_macros.php(218): XF\Template\Templater->renderExtension('full_body', Array, Object(XF\Template\ExtensionSet))
#8 src/XF/Template/Templater.php(922): XF\Template\Templater->{closure}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#9 src/addons/MaZ/AMP/XF/Template/Templater.php(159): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array, Object(XF\Template\MacroState))
#10 internal_data/code_cache/templates/l1/s10/public/thread_view.php(887): MaZ\AMP\XF\Template\TemplaterAbstract->callMacro(NULL, 'post_macros::po...', Array, Array)
#11 src/XF/Template/Templater.php(1792): XF\Template\Templater->{closure}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#12 src/addons/MaZ/AMP/Traits/Templater/XF22.php(52): XF\Template\Templater->renderTemplate('thread_view', Array, true, NULL)
#13 src/addons/MaZ/AUN/XF/Template/Templater.php(39): MaZ\AMP\XF\Template\Templater->renderTemplate('public:thread_v...', Array, true, NULL)
#14 src/XF/Template/Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('public:thread_v...', Array)
#15 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#16 src/XF/Mvc/Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#17 src/XF/Mvc/Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#18 src/XF/Mvc/Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#19 src/XF/Mvc/Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#20 src/XF/App.php(2826): XF\Mvc\Dispatcher->run()
#21 src/XF.php(806): XF\App->run()
#22 index.php(23): XF::runApp('XF\\Pub\\App')
#23 {main}
[HEADING=2]Request state[/HEADING]
array(4) {
  ["url"] => string(19) "/threads/w00t.8728/"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
 
MentaL said:
Also

X

Post in thread 'User Mentions Improvements by Xon'

apathy\StyleSuite (or some other add-on) is incorrectly adding a return type that doesn't exist in stock XF.

Newer phpstorm versions are better at not suggesting adding a return type to functions which are missing it when they override an existing method
  • Like
Click to expand...
I have this one caught already, but not https://xenforo.com/community/threads/ap-style-suite-paid.191830/post-1708006

I was hoping to get another feature update out today but I havent had time to finish it off, so it'll just be a hotfix that's out later, but all these issues should be sorted
 
apathy said:
I have this one caught already, but not https://xenforo.com/community/threads/ap-style-suite-paid.191830/post-1708006

I was hoping to get another feature update out today but I havent had time to finish it off, so it'll just be a hotfix that's out later, but all these issues should be sorted
Click to expand...
That plus remote URL embed = gold! Itll bypass the limitations of local encoding from Imagick and allow the use of other animated extensions and thus higher quality imagery. Although the bandwidth will be higher for the end user.
 
apathy updated [AP] Style Suite with a new update entry:

2.12.1

  • Fix type hinting issue in extended admin controllers
  • Fix Argument #3 ($user) must be of type XF\Entity\User, null given
  • Correctly fetch postbit preview images
  • Fix issue where trying to replace an image asset (e.g. avatar frame) would result in a broken image
  • Correctly bundle the rewritten JS usertagging fix for Siropu Chat 2
  • Fix Undefined variable $output when managing profile blocks
  • Skip over fonts during a fresh install if...
Click to expand...

Read the rest of this update entry...
 
apathy updated [AP] Style Suite with a new update entry:

2.13.0

  • Create "Disable the following assets" admin option
  • Merge all "Disable profile block" admin options into a single option
  • Create "Allowed CSS properties" admin option for choosing which properties can be applied in custom CSS fields
  • Remove a users' set asset if their group of the chosen style types has been removed from the assets options
  • Allow embedding/hotlinking of assets
  • Merge "Manage avatar frames/fonts/sparkles/postbit presets" admin permissions into "Manage...
Click to expand...

Read the rest of this update entry...
 
Code: 
LogicException: Class apathy\StyleSuite\Service\Admin\AssetImageService does not exist in src/XF/Container.php at line 272
XF\Container->createObject() in src/XF/App.php at line 1968
XF\App->XF\{closure}() in src/XF/Container.php at line 233
XF\Container->create() in src/XF/App.php at line 3550
XF\App->service() in src/addons/apathy/StyleSuite/Job/AssetOptimization.php at line 52
apathy\StyleSuite\Job\AssetOptimization->optimizeById() in src/XF/Job/AbstractImageOptimizationJob.php at line 27
XF\Job\AbstractImageOptimizationJob->rebuildById() in src/XF/Job/AbstractRebuildJob.php at line 42
XF\Job\AbstractRebuildJob->run() in src/XF/Job/AbstractImageOptimizationJob.php at line 18
XF\Job\AbstractImageOptimizationJob->run() in src/XF/Job/Manager.php at line 275
XF\Job\Manager->runJobInternal() in src/XF/Job/Manager.php at line 205
XF\Job\Manager->runJobEntry() in src/XF/Job/Manager.php at line 121
XF\Job\Manager->runByIds() in src/XF/Admin/Controller/ToolsController.php at line 146
XF\Admin\Controller\ToolsController->actionRunJob() in src/XF/Mvc/Dispatcher.php at line 362
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 264
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 121
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 63
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2826
XF\App->run() in src/XF.php at line 806
XF::runApp() in admin.php at line 15
 
i dont know how my users found a way to break everything




Code: 
ErrorException: [E_WARNING] Undefined array key "avatar_frame" src/addons/apathy/StyleSuite/ControllerPlugin/UserStyle.php:42
Generated by: Lucien Oct 1, 2024 at 9:14 PM
Stack trace
#0 src/addons/apathy/StyleSuite/ControllerPlugin/UserStyle.php(42): XF::handlePhpError(2, '[E_WARNING] Und...', '/www/wwwroot/fo...', 42)
#1 src/addons/apathy/StyleSuite/Pub/Controller/UserStyleController.php(94): apathy\StyleSuite\ControllerPlugin\UserStyle->getActiveAssets()
#2 src/XF/Mvc/Dispatcher.php(362): apathy\StyleSuite\Pub\Controller\UserStyleController->actionIndex(Object(XF\Mvc\ParameterBag))
#3 src/XF/Mvc/Dispatcher.php(264): XF\Mvc\Dispatcher->dispatchClass('apathy\\StyleSui...', 'Index', Object(XF\Mvc\RouteMatch), Object(apathy\StyleSuite\Pub\Controller\UserStyleController), NULL)
#4 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(apathy\StyleSuite\Pub\Controller\UserStyleController), NULL)
#5 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(2826): XF\Mvc\Dispatcher->run()
#7 src/XF.php(806): XF\App->run()
#8 index.php(23): XF::runApp('XF\\Pub\\App')
#9 {main}
Request state
array(4) {
  ["url"] => string(23) "/cuenta/style-settings/"
  ["referrer"] => string(22) "https://foroscuba.com/"
  ["_GET"] => array(1) {
    ["/cuenta/style-settings/"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}
 
I've initially contacted you about some errors on your platform. I was looking at the files and it looks like the values were sent as strings and the data type in the database was integer. I've changed the type to varchar and it looks like it works for now. The only thing that doesn't is the icon but I will wait for your fix instead.

Regards
 
You must log in or register to reply here.
Back
Top Bottom