Fixed AnalyzeUsage::analyzeUnfurlUsage is very fragile

[Xon]

Affected version

2.2.8 Patch 1

XF\BbCode\ProcessorAction\AnalyzeUsage::analyzeUnfurlUsage is written as a final hook, meaning it works on final text and not per tag via a tag hook which has access to parsed options. This causes the code to need to extract/detect the unfurl attribute and url contents twice.

This results in the unfurl format in the analyzer being very fragile, and doesn't really matched how unfurl handling works elsewhere.

For example;

[url test="1" unfurl="true"]https://xenforo.com/community[/url]


Will render as an unfurled tag, but analyzeUnfurlUsage will not detect it.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.9).

Change log:

Make unfurl usage analysis more robust

There may be a delay before changes are rolled out to the XenForo Community.

 

[Jeremy P]

Since tag hooks have a different signature, this is handled via a new method. The existing method still exists and runs to avoid BC issues, but no longer does anything by default.