Ads Manager 2 by Siropu

Ads Manager 2 by Siropu [Paid] 2.8.3

No permission to buy (€50.00)
There is a bug with this column not beeing added in the install process but added in the upgrade and It will be fixed soon.
SQL:
ALTER TABLE xf_siropu_ads_manager_ad_extra
    ADD COLUMN is_featured TINYINT(1) NOT NULL DEFAULT 0;
 
Seems to work after these 2 queries. Note: if you select Sticky or Featured first, without filling in any fields, and then uncheck them or one of them, the boxes become greyed out until you select a forum.
 
Last edited:
Can anyone give me pointers on how to rotate two different types in a location?

Have a 728x90 ad and then want to also use Adsense. Surely this is possible?
 
There appears to be a bug in Featured thread.

Example:
Set to $5/week.
Go to frontend, make it 2 weeks, 3 weeks, 4 weeks, the total cost does not move it stays at $5.
 
Suggestion: Can you add phrases for Stick thread and Feature thread, if I change them it changes in all of XF since you use their phrases. I want to modify them to make them a little more exciting, like "Feature it!" etc. Thanks!
 
HTML5 NIGHTMARES.
We have a client who sends us HTML5 banners and they always create problem. It looks like there is too much code, plus images embedded in the code, etc. I worked trying to strip them of their bloat but it only works in a browser, not in Ads Manager where it break. Can you help?

I test the code here https://codeshack.io/html-viewer/.

What I receive:

chrome_5bZcJUJ9fj.webp

After I remove the wrapper. (the banner actually shows in its entirety, this is just a browser limitation for this screenshot)

chrome_UCeWgeE0jd.webp

BUT when I paste this in Ads Manager, I get this error.

chrome_gGImFsCUwZ.webp


chrome_wSms7iwtLP.webp

What are the instructions we should give clients so it works immediately? Last time I spent two day on this in a back and forth with the client because the ads looked all off, fonts misplaced, images displaced, etc.

I have one day to fix this, or we tell the client how to properly package his ads. We shouldn't be spending hours on this to repair what will come broken again next time.

Do you have a fix?

Regards,

Andre
 
I would like to change the phrasing of discounts. I want to use the (+) sign instead of greater than/equal to.

Code:
In package now:
>= 1 Day (25% Discount)
>= 7 Days (50% Discount)

Want to change to:
1+ Day (25% Discount)
7+ Days (50% Discount)

In Discounts pop-up now:
1 Day 25%
7 Days 50%

Want to change to:
1+ Day 25%
7+ Days 50%

The (+) sign seems much much intuitive, and that's the way it works. It is not in phrases can you let me know what to change? Thanks!
 
@Siropu

Bug: Invoice remains marked as recurring after switching to one-time payment

In Ads Manager 2.8.2, if a user selects Subscribe, initiates checkout, and then abandons payment, the invoice's recurring field is set to 1.

If the user returns to the same pending invoice, leaves Subscribe unchecked, and initiates a one-time payment, recurring incorrectly remains 1. I reproduced this on XenForo 2.3 using the PayPal Sandbox for the abandoned checkout and Test Payment via [OzzModz] Payment Provider Test to complete the invoice.

The issue appears to be in Purchasable/Advertising.php::getPurchaseFromRequest(), which sets recurring = 1 when selected but never resets it to 0 when unchecked.

Expected behavior: The invoice's recurring status should reflect the user's latest checkout selection, preventing an unintended subscription.
 
@Siropu can a user buy an image ad package and upload one banner for web, one for mobile for the same location?

Any help here? What two templates can I edit if I have to?
I would like to change the phrasing of discounts. I want to use the (+) sign instead of greater than/equal to.

Code:
In package now:
>= 1 Day (25% Discount)
>= 7 Days (50% Discount)

Want to change to:
1+ Day (25% Discount)
7+ Days (50% Discount)

In Discounts pop-up now:
1 Day 25%
7 Days 50%

Want to change to:
1+ Day 25%
7+ Days 50%

The (+) sign seems much much intuitive, and that's the way it works. It is not in phrases can you let me know what to change? Thanks!
 
Last edited:
No. Different sizes? Like a 728x90 and 250x250?
Yes. A 728x90 can look great on web, on phone it is not as legible and could be changed to a 320x100. Ai suggests to do a code ad and use css for the change and they upload both banners, but you recommend we don't sell code ads. So was looking for a solution. Thanks
 
I still can't sell this package as the cost calculation is broken, is this a bug or my install since I upgraded from that test version?

There appears to be a bug in Featured thread.

Example:
Set to $5/week.
Go to frontend, make it 2 weeks, 3 weeks, 4 weeks, the total cost does not move it stays at $5.
 
Ads Manager 2.8.2 regression: Content lazy loading fails for zero-height ad containers

After upgrading from Ads Manager 2.7.1 to 2.8.2, I discovered that several advertisements using content lazy loading were no longer loading, even when scrolling to their positions.

I've traced this to a change in js/siropu/am/core.min.js.

Version 2.7.1:

JavaScript:
function isScrolledIntoView(elem) {
// Checks whether the element is inside the viewport
}
This allowed zero-height lazy-loading placeholders to pass the visibility check when positioned within the viewport.

Version 2.8.2:

JavaScript:
function isScrolledIntoView(elem, threshold = 0.5) {
if (elem) {
const rect = elem.getBoundingClientRect();
if (rect.height) {
// New visibility calculation
}
}
}
The new if (rect.height) condition prevents zero-height placeholders from passing the visibility check.

Reproduction:
  1. Create a Code advertisement with content lazy loading enabled, using a container without an explicitly reserved height.
  2. Load the page and scroll to the advertisement.
  3. The .samLazyLoading element remains at 0px height, and the advertisement never loads.
  4. Give the lazy-loading element min-height: 1px using CSS, refresh, and scroll to the advertisement. It now loads successfully.
I've reproduced this with both sam-item and sam-unit lazy-loading arrangements. The problem affects advertisements in multiple positions, including native XenForo positions.

This appears to create a circular dependency: the advertisement needs to load to acquire its height, but the new visibility check requires it to have height before loading.

Could you adjust the visibility detection to account for zero-height lazy-loading placeholders while retaining the new visibility threshold for elements with actual dimensions?
 
If I could, I would improve two things about this add-on:
  • On the advertiser page, which is currently limited to BBCode only, I would allow the use of HTML and CSS.
  • And I would add a “bundle” feature that allows users to purchase multiple ads at once, even at a discounted price.
 
Siropu updated Ads Manager 2 by Siropu with a new update entry:

Improvements & Bug Fixes

Added admin option "Display discount radio buttons" to allow quick selection based on purchase value.
Added two new phrases: siropu_ads_manager_stick_thread and siropu_ads_manager_feature_thread

Fixed an issue with price calculation for Featured thread and Featured media ad types.
Fixed an issue with Invoice subscription option remaining checked after it has been previously checked but not payed and then unchecked before paying the invoice.
Fixed an issue with lazy loading.

Read the rest of this update entry...
 
Back
Top Bottom