Resource icon

Ads Manager 2 by Siropu [Paid] 2.3.11

No permission to buy (€49.99)

Siropu

Well-known member
It is working fine for me. What are you using with Item ID? Have you made any other changes?
 

rdn

Well-known member
I hope you can improve or change how to multi select on Position option.
Right now it's very hard to track what's selected.

Take a look at how Discourse implement multi select, it's awesome and easy to use.

Sample

195071
 

Joe Link

Well-known member
I figured out my prior error and all my data imported successfully :)

I do have these two from my second attempt, any ideas?

Code:
Server error log
ErrorException: [E_NOTICE] Undefined index: siropuAdsManagerStickyThreadPrefix src/addons/Siropu/AdsManager/Service/Ad/Toggler.php:20
Generated by: Joe Link Feb 7, 2019 at 3:37 PM
Stack trace
#0 src/addons/Siropu/AdsManager/Service/Ad/Toggler.php(20): XF::handlePhpError(8, '[E_NOTICE] Unde...', '/home/nginx/dom...', 20, Array)
#1 src/addons/Siropu/AdsManager/Entity/Ad.php(1249): Siropu\AdsManager\Service\Ad\Toggler->toggleSticky(1)
#2 src/addons/Siropu/AdsManager/Entity/Ad.php(1339): Siropu\AdsManager\Entity\Ad->toggleSticky(1)
#3 src/XF/Mvc/Entity/Entity.php(1208): Siropu\AdsManager\Entity\Ad->_postSave()
#4 src/addons/Siropu/AdsManager/Setup.php(294): XF\Mvc\Entity\Entity->save(false)
#5 src/XF/AddOn/StepRunnerUpgradeTrait.php(122): Siropu\AdsManager\Setup->upgrade2000035Step3(Array)
#6 src/XF/AddOn/StepRunnerUpgradeTrait.php(71): Siropu\AdsManager\Setup->upgradeStepRunner(2000035, 3, Array, 2000170)
#7 src/XF/Job/AddOnInstallBatch.php(293): Siropu\AdsManager\Setup->upgrade(Array)
#8 src/XF/Job/AddOnInstallBatch.php(86): XF\Job\AddOnInstallBatch->stepAction(Object(XF\Timer))
#9 src/XF/Job/Manager.php(253): XF\Job\AddOnInstallBatch->run(G)
#10 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#11 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#12 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#13 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#14 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#15 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#16 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#17 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#18 src/XF.php(390): XF\App->run()
#19 admin.php(13): XF::runApp('XF\\Admin\\App')
#20 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(58) "https://domain.com/admin.php?tools/run-job"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
    ["_xfRedirect"] => string(93) "https://domain.com/admin.php?add-ons/install-from-archive-complete&batch_id=4"
    ["_xfToken"] => string(8) "********"
    ["only_ids"] => string(2) "39"
  }
}
Code:
Server error log
ErrorException: Renamed column xf_siropu_ads_manager_package.cost_sticky to cost_sticky__conflict to avoid schema conflict src/XF/Error.php:75
Generated by: Joe Link Feb 7, 2019 at 3:37 PM
Stack trace
#0 src/XF.php(187): XF\Error->logError('Renamed column ...', true)
#1 src/XF/Db/Schema/Column.php(381): XF::logError('Renamed column ...', true)
#2 src/XF/Db/Schema/Alter.php(238): XF\Db\Schema\Column->getDefinition()
#3 src/XF/Db/Schema/AbstractDdl.php(147): XF\Db\Schema\Alter->getQueries()
#4 src/XF/Db/SchemaManager.php(149): XF\Db\Schema\AbstractDdl->apply()
#5 src/addons/Siropu/AdsManager/Setup.php(638): XF\Db\SchemaManager->alterTable('xf_siropu_ads_m...', Object(Closure))
#6 src/XF/AddOn/StepRunnerUpgradeTrait.php(122): Siropu\AdsManager\Setup->upgrade2030070Step1(Array)
#7 src/XF/AddOn/StepRunnerUpgradeTrait.php(71): Siropu\AdsManager\Setup->upgradeStepRunner(2030070, 1, Array, 2030270)
#8 src/XF/Job/AddOnInstallBatch.php(293): Siropu\AdsManager\Setup->upgrade(Array)
#9 src/XF/Job/AddOnInstallBatch.php(86): XF\Job\AddOnInstallBatch->stepAction(Object(XF\Timer))
#10 src/XF/Job/Manager.php(253): XF\Job\AddOnInstallBatch->run(G)
#11 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#12 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry(Array, G)
#13 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds(Array, 8)
#14 src/XF/Mvc/Dispatcher.php(321): XF\Admin\Controller\Tools->actionRunJob(Object(XF\Mvc\ParameterBag))
#15 src/XF/Mvc/Dispatcher.php(248): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#16 src/XF/Mvc/Dispatcher.php(100): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\Tools), NULL)
#17 src/XF/Mvc/Dispatcher.php(50): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#18 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#19 src/XF.php(390): XF\App->run()
#20 admin.php(13): XF::runApp('XF\\Admin\\App')
#21 {main}
Request state
array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(58) "https://domain.com/admin.php?tools/run-job"
  ["_GET"] => array(1) {
    ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
    ["_xfRedirect"] => string(93) "https://domain.com/admin.php?add-ons/install-from-archive-complete&batch_id=4"
    ["_xfToken"] => string(8) "********"
    ["only_ids"] => string(2) "39"
  }
}
 
Last edited:

Joe Link

Well-known member
@Siropu

I'm not seeing this position in the XF2 version (it was very popular in XF1.5). Did the name change or was it removed? Any chance you can add it back in?

195493
 

JulianD

Well-known member
I want to report a couple of bugs that I have found while using this addon:

1. If I clone an ad with the "Inherit package settings" checked, such option will always be selected even if I save the ad without it checked. It's very annoying.
2. If you take the same ad (not sure if you can replicate it on a non-duplicated ad) and set the Display priority to 1, the following PHP errors start filling the error log:

ErrorException: Template error: Cannot call method getAttributes on a non-object (NULL) src/XF/Template/Templater.php:963

Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Cannot call met...', '/home/laneros/p...', 963, Array)
#1 src/XF/Template/Templater.php(963): trigger_error('Cannot call met...', 512)
#2 internal_data/code_cache/templates/l5/s43/public/siropu_ads_manager_ad_macros.php(142): XF\Template\Templater->method(NULL, 'getAttributes', Array)
#3 src/XF/Template/Templater.php(694): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Array)
#4 internal_data/code_cache/templates/l5/s43/public/siropu_ads_manager_ad_macros.php(76): XF\Template\Templater->callMacro('siropu_ads_mana...', 'ad_code', Array, Array)
#5 src/XF/Template/Templater.php(694): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Array)
#6 internal_data/code_cache/templates/l5/s43/public/thread_view.php(526): XF\Template\Templater->callMacro('siropu_ads_mana...', 'ad_unit', Array, Array)
#7 src/XF/Template/Templater.php(1294): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array)
#8 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array)
#9 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#10 src/XF/Mvc/Dispatcher.php(418): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#11 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(360): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(53): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#14 src/XF/App.php(2177): XF\Mvc\Dispatcher->run()
#15 src/XF.php(390): XF\App->run()
#16 index.php(20): XF::runApp('XF\\Pub\\App')
#17 {main}
3. If I create an affiliate link ad, the affiliation doesn't work on an unfurled link, although it works just fine on a regular link.

That's all so far, other than that, great product!
 
Top