1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Admin Template Modifications Counters

Discussion in 'Resolved Bug Reports' started by digitalpoint, Nov 7, 2013.

  1. digitalpoint

    digitalpoint Well-Known Member

    It seems every upgrade I do, all my admin template modifications get the counter showing how many times it was applied increased by 1. For example under 1.2.2, they were all set to 3. After upgrading to 1.2.3, they are now all 4. Each template modification is only applied once.

    upload_2013-11-6_21-39-13.png

    Disabling them rolls it back to 3, but obviously that's not right either.

    upload_2013-11-6_21-39-54.png
     
    Adam Howard likes this.
  2. Jeremy

    Jeremy XenForo Moderator Staff Member

    I believe it is a cumulative number and it reapplied TMs after each upgrade (hence 3 to 4).
     
  3. digitalpoint

    digitalpoint Well-Known Member

    Yeah, that's my guess too... but I assume it's not supposed to work that way? :)
     
  4. Jeremy

    Jeremy XenForo Moderator Staff Member

    I think it's supposed to be cumulative. Unless I misunderstand what you are reporting.
     
  5. Lawrence

    Lawrence Well-Known Member

    My TMS counts are mostly 1s and 2s, with one being at 4 (even after the upgrade to 1.2.3, some are still at 1). Doesn't the count also include the number of times within a template the modification was applied? The one with 4 had the modification applied twice (as expected) in both of my styles (Master and my Icewind style).
     
  6. digitalpoint

    digitalpoint Well-Known Member

    Not sure how useful a cumulative counter would be for the number of times a template modification has ever been applied in the history of the world.

    If that *is* how it's designed, then the non-admin template modifications counter is broken because it's *not* cumulative over the history of time, rather it's a more useful number of the number of changes made to the existing template.
     
    Daniel Hood likes this.
  7. Jeremy

    Jeremy XenForo Moderator Staff Member

    Well, I completely misread that bug report. lol. Didn't realize it was only cumulative on Admin modifications.
     
  8. Mike

    Mike XenForo Developer Staff Member

    This is fixed now. It applied to a few other cases, including email templates and possibly when deleting styles. I've added some queries to clean up the data that shouldn't be there as well.
     
    Bob likes this.

Share This Page