cclaerhout
Well-known member
Arty styles are not only responsive, they are also good looking. So no need to screamArty's secretly screaming, "Nooooooooooooooooooooooooooooooo! Curse you XenForo!"
Arty styles are not only responsive, they are also good looking. So no need to screamArty's secretly screaming, "Nooooooooooooooooooooooooooooooo! Curse you XenForo!"
I'd be lost without your sitemap add on, but it's one of the things I really do think should be part of the core.That should be the pattern. Taking the most popular add-ons and integrating them into the core.
Things like the tagging (BD Tag Me) should be core
And things like the sidebar (BD Widget) should also be core
I have found myself integrating with those add-ons just because I need to, at that point, it should really be part of the main package
There are, however, some things that are better done by the developers
It is nice to have new features, but it is also nice to enable the enablers, and add things that will further give the community the opportunity to create better addons.
- Any platform enhancements to make the system more robust
- The algorithm for rebuilding styles gets ugly past certain barrier
- Still no parsed posts, bbcode is parsed every time
- Mail is still underfeatured
.... they introduced post history, I am going to use that in blogs as soon as it is released
.... they introduced TMS, that is a huge win for developers, I will stop asking for hooks (and jumping through hoops)
P.S. Just leave my sitemap add-on alone
See http://xenforo.com/community/threads/an-update-about-mobile.47937/#post-514176When will be Mobile Style?
Is it responsive or separate style/addon?
That should be the pattern. Taking the most popular add-ons and integrating them into the core.
Things like the tagging (BD Tag Me) should be core
And things like the sidebar (BD Widget) should also be core
7. Description for RSS deprecated by RSS Content Snippets
Not sure how you could make mail more feature-rich, but it's been noted that mail queuing would be added in xF 1.2.
- Mail is still underfeatured
Not sure this is true. xF 1.2 will still rebuild all caches.8. Faster Addon Cache Rebuild deprecated by some of this stuff mentioned in Assorted Small Things.
I posted it because the title is "Faster Addon Cache Rebuild" which makes average people think "oh it makes rebuilding stuff faster? cool!" installs. Which is what the stuff mentioned in Assorted Small Things also says it's gonna do.Not sure this is true. xF 1.2 will still rebuild all caches.
The above add-on is unlikely to be core, because it makes an assumption that the only place new templates/phrases etc. will be added is in the XML file, which simply is not true.
That's not true.The above add-on is unlikely to be core, because it makes an assumption that the only place new templates/phrases etc. will be added is in the XML file, which simply is not true.
public function getCachesForRebuild($addonId)
{
/** @var $phraseModel XenForo_Model_Phrase */
$phraseModel = $this->getModelFromCache('XenForo_Model_Phrase');
$phrases = $phraseModel->getMasterPhrasesInAddOn($addonId);
if (count($phrases) > 0) {
FasterAddonCacheRebuild_Static::$addonCaches[] = FasterAddonCacheRebuild_Static::CACHE_PHRASE;
}
/** @var $adminTemplaetModel XenForo_Model_AdminTemplate */
$adminTemplaetModel = $this->getModelFromCache('XenForo_Model_AdminTemplate');
$adminTemplates = $adminTemplaetModel->getAdminTemplatesByAddOn($addonId);
if (count($adminTemplates) > 0) {
FasterAddonCacheRebuild_Static::$addonCaches[] = FasterAddonCacheRebuild_Static::CACHE_ADMINTEMPLATE;
}
/** @var $publicTemplateModel XenForo_Model_Template */
$publicTemplateModel = $this->getModelFromCache('XenForo_Model_Template');
$templates = $publicTemplateModel->getMasterTemplatesInAddOn($addonId);
if (count($templates) > 0) {
FasterAddonCacheRebuild_Static::$addonCaches[] = FasterAddonCacheRebuild_Static::CACHE_TEMPLATE;
}
/** @var $emailTemplateModel XenForo_Model_EmailTemplate */
$emailTemplateModel = $this->getModelFromCache('XenForo_Model_EmailTemplate');
$emailTemplates = $emailTemplateModel->getMasterEmailTemplatesByAddOn($addonId);
if (count($emailTemplates) > 0){
FasterAddonCacheRebuild_Static::$addonCaches[] = FasterAddonCacheRebuild_Static::CACHE_EMAILTEMPLATE;
}
return FasterAddonCacheRebuild_Static::$addonCaches;
}
That's not true.
It checks which data are added by the addon (templates,phrases, admintemplates,emailphrases,...) and rebuilds only the caches, which needs the rebuild
If the addon contains only templates, it will rebuild only templates
If the addon contains templates,phrases, it will rebuild templates and phrases
if the addon contains only admintemplates, it will rebuild only admin templates
No, it's something for the core, addons shouldn't be responsible for this!I suppose you could argue that it would be up to the add-on developer to force that template/phrase to be compiled.
My point is that this CAN'T be added to the core (at least not the way you have done it) because that assumption cannot be made. For example, I might have an add-on that replaces a template in another add-on (this would have to be done in the PHP installer file, not the XML). Your add-on would not pick that up and would therefore not re-compile it.No, it's something for the core, addons shouldn't be responsible for this!
BUT, i don't see any reason why the addon would need to force a compile of templates/phrases and the other elements, if the addon doesn't include & remove any while the installation & deinstallation.
Isn't this already done inside the datawriters(if you don't disable the option), but yes i agree, it's dangerous, and wouldn't work IF an addon changes data via an query instead of the datawritersTo do this perfectly, there would have to be something that tracks any requests to the phrase/template datawriters and then (re)compiles any phrases/templates that have not been (re)compiled.
To do this perfectly, there would have to be something that tracks any requests to the phrase/template datawriters and then (re)compiles any phrases/templates that have not been (re)compiled.
It was obvious to me, I welcome the removal of addons and using the core xf setupWhile it usually is a good idea to fully explain your intent when starting a thread, I think this was a bit obvious where he was going with it. I could be wrong.
We use essential cookies to make this site work, and optional cookies to enhance your experience.