XF 2.2 Addon template modification

[Anatoliy]

So I'm building my first addon that will deal with too long thread titles. So far it can find threads with title length longer than 70 characters and list them.
What I want to do next is to bulk fix them by removing " | Board title" from their titles. So I created a PAGE_CONTAINER template modification that will replace

<title><xf:title formatter="%s | %s" fallback="{$xf.options.boardTitle}" page="{$pageNumber}" /></title>

with

<title>
<xf:if is="$noBoardTitle">
<xf:title formatter="%s" fallback="{$xf.options.boardTitle}" page="{$pageNumber}" />
<xf:else />
<xf:title formatter="%s | %s" fallback="{$xf.options.boardTitle}" page="{$pageNumber}" />
</xf:if>
</title>

The question - what would be the best field for storing the "mark" that thread title is too long?
Probably an extra column in xf_threads table, but frankly I'm too afraid to touch xf tables. )
What about a thread custom field? I could create it from ACP so it looks safe. Or it will require an extra query when rendering a thread page?

Will be appreciate for any advice.
Thanks in advance.

 

[NikitOS]

Maybe you can check the page title length directly in the template using strlen($pageTitle)?

 

[Anatoliy]

Maybe you can check the page title length directly in the template using strlen($pageTitle)?

That would be actually cool. No need to "mark" long title threads. But is it possible? I understood that all php code goes into Controller and a template can only get variables.

 

[Anatoliy]

Either I'm high or <xf:if is="strlen($pageTitle) > 50"> really works. )

P.S. NikitOS, spasibo, drug!

 

[Paul B]

Yes, it will work fine.

You can use strlen for any vars of that nature: https://xenforo.com/community/threads/post-length-conditional.201716/#post-1554400

 

[Anatoliy]

And one more question please. How do I get Board Title value from my controller?

 

[NikitOS]

And one more question please. How do I get Board Title value from my controller?

\XF::options()->boardTitle.

 

[Anatoliy]

\XF::options()->boardTitle.

SPASIBO!!! )

 

[Anatoliy]

oops... just noticed that forum list and category shows an error

Template errors​

• Template publicAGE_CONTAINER: [E_DEPRECATED] utf8_decode(): Passing null to parameter #1 ($string) of type string is deprecated (src\vendor\dokuwiki\utf8\utf8.php:141)

Here's what I have in template modification

<title>
<xf:if is="{{strlen($pageTitle) > 50}}">
<xf:title formatter="%s" fallback="{$xf.options.boardTitle}" page="{$pageNumber}" />
<xf:else />
<xf:title formatter="%s | %s" fallback="{$xf.options.boardTitle}" page="{$pageNumber}" />
</xf:if>
</title>

 

[Anatoliy]

AGE_CONTAINER

 

[NikitOS]

There is no page title at this location, so an error occurred. Try this: strlen($pageTitle ?: '').

 

[Anatoliy]

There is no page title at this location, so an error occurred. Try this: strlen($pageTitle ?: '').

Thanks!

 

[Anatoliy]

So if I already used

php cmd.php xf-addon:build-release AV/Titles

to build my addon, and now I made changes to it, what command do I use to build(release?) the next version?

I used the same command expecting it will create next version, but it created again AV-Titles-1.0.0 Alpha zip, that overrided the previous one.

 

[NikitOS]

The command is the same. If you want to change the version, you need to edit the addon.json file and sync the changes using the admin cp or xf-addon:sync-json command.

 

[Paul B]

Don't you use php cmd.php xf-addon:bump-version ?

 

[Anatoliy]

php cmd.php xf-addon:bump-version

Oh, yeah! That's what I was looking for. )
But now another question - Current version ID: 1000010. So what id goes next? 1000011?

 

[Paul B]

Versioning is based on whether it's a first, second, or third point release.

Add-on structure | Developer Documentation | XenForo

Developer documentation for XenForo

xenforo.com

 

[Anatoliy]

Versioning is based on whether it's a first, second, or third point release.

that is Chinese for me )))

Version ID set to: 1000011
Version string set to: 1.0.0 Alpha 1
The addon.json file was successfully written out to C:\xampp\htdocs\xf\src\addons\AV\Titles\addon.json
Add-on successfully updated to version 1.0.0 Alpha 1 (1000011).

But I still see AV-Titles-1.0.0 Alpha zip in _releases. It means now I have to run

php cmd.php xf-addon:build-release

?

 

[Paul B]

that is Chinese for me )))

If your release is 1.0.0 Alpha 1 then the version string should be 1000011.

If the next release is 1.0.0 Alpha 2 then it would be 1000012.

 

[Anatoliy]

If your release is 1.0.0 Alpha 1 then the version string should be 1000011.

If the next release is 1.0.0 Alpha 2 then it would be 1000012.

I got that. I thought it would put archives into _releases so all of them would be acceptable if "oops" happens and I need to quickly revert back to the previous version.

So now after

php cmd.php xf-addon:bump-version

it shows "Thread Title Length 1.0.0 Alpha 1" under installed addons on my local dev server. I'd like to upgrade from Alpha to Alpa 1 on my production xF, but I'm kind of scared because zip still has name Alpha and not Alpha 1 as I would expect.