Fixed Add-on Style Property Groups not deleted

[ragtek]

If you have a add-on with style property groups and you deinstall it, they won't be removed!

steps to reproduce:

create add-on
create style property group + style properties and associate them to the add-on
deinstall the add-on

the phrases are removed, but you'll see the style property groups still in the list

 

[ragtek]

possible fix:

add

$this->getModelFromCache('XenForo_Model_StyleProperty')->deleteStylePropertyGroupsInStyle(-1, $addOnId, true);
$this->getModelFromCache('XenForo_Model_StyleProperty')->deleteStylePropertyGroupsInStyle(0, $addOnId, true);

to XenForo_Model_AddOn::deleteAddOnMasterData

ps:
also the property group isn't selected, if you create a prop group and click the first time on it and get redirected to the "create new property form".

 

[Mike]

Fix looks good, though the function only takes 2 arguments. Thanks.