Fixed AbstractFieldMap defines field_id as UINT but AbstractField defines it as STR

DragonByte Tech

Well-known member
Affected version
2.0.1
Unless I'm horribly misunderstanding how this works, 'field_id' => ['type' => self::UINT, 'required' => true] is the wrong definition in the AbstractFieldMap class.

In the xf_forum_field database table, field_id is also varbinary as it is in the xf_thread_field table, so I feel like something is horribly wrong here, somewhere.


Fillip
 
I'm pretty sure you're right - ForumField extends AbstractFieldMap, and the ForumField refers to xf_forum_field, which certainly does have a field_id STR column.

What I haven't quite worked out yet is how this hasn't blown up spectacularly when associating thread fields with nodes...

Nonetheless, I've updated the AbstractFieldMap definition to fix the problem.
 
Back
Top Bottom