Fixed 2.2 Pseudo double-post

[beerForo]

Affected version

2.2

So I replied here: https://xenforo.com/community/threa...tom-ban-reasons-when-issuing-warnings.183393/

I left the page open a few seconds and it said the thread was updated so I clicked. It loaded my post again so I saw it successfully posted twice. So I deleted the "new" one. Then both were gone and my post text was in the editor.

So it was never double posted and I deleted my post. So I clicked to submit it again.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.0 RC2).

Change log:

Avoid the appearance of a double post due to a draft saving race condition

There may be a delay before changes are rolled out to the XenForo Community.

 

[Mike]

This is sort of a "partial fix", though it does resolve the primary issue reported (in at least the vast majority of cases).

This was caused by the draft save request being triggered just before you actually clicked post reply, but it being processed more slowly so by the time it came to checking for new content, it found your new post. I've added some extra checks in JS to ignore this if there's been a post in the interim.

The part that is much harder to resolve in this case is the post text being stored as a draft, even though you've just submitted it. The QR submission would wipe out the draft, but it then gets recreated by the slow-moving draft request. So this part could still happen, but it should generally be quite rare.