Fixed Non-Helpful error message when trying to upload a file

[Kirby]

Affected version

2.1.7

If I try to upload a file that has an extension which is not allowed by configuration I do get the following error message:
The uploaded file does not have an allowed extension.

While this is surely correct, it isn't really helpful - I still do not know afterwards which files would be allowed.

This message should state which file extensions are allowed or lnk to a place that does give this info.

 

[djbaxter]

AdminCP >> Setup>> Options >> Attachments

 

[SeToY]

This message should state which file extensions are allowed or lnk to a place that does give this info.

AdminCP >> Setup>> Options >> Attachments

The regular regular most likely does not have access to the Admin CP.

 

[Kirby]

@djbaxter
Well, I know where to find this info - but a normal user does not (nor can't he access ACP)

 

[djbaxter]

Gotcha. In that case, I would modify the phrase to add something like "Please contact an administrator with the name and extension of the file you are trying to upload."

and/or add the list of allowed extensions to the phrase.

 

[Kirby]

Yeah, I did smth. similar - I added a help page with all (dynamically generated) info about attachments (allowed extensions, max. filesize, max dimensions, max allowed attachments/post and max resize pixel count) and added a link to that page when an upload error does happen.

Nevertheless, I feel that this is a bug somewhat similar to other not-that-helpful error messages like

Fixed - Confusing error message when trying to save account details with certain custom fields

If a custom textfield is configured as value type color and has a low maximum length (like 2) configured, the user does get a confusing error message when trying to save accout details: : Please enter a value using 2 characters or fewer. This most likely applies to other types as well...

xenforo.com

Fixed - Confusing error message when saving user

Steps to reproduce Create a new textbox custom profile field Create a new user and make sure this user has the value test in the profilefield created in step 1 Edit the profile field created in step one and add the regex ^\d+$ Edit the user created in step 2, click set new password, enter a...

xenforo.com

and therefore should be addressed in core.

 

[Mike]

I haven't necessarily investigated in more detail, but we pass the allowed list of extensions into the upload inputs in most cases, so the OS/browser would generally be responsible for filtering to only show allowed file types (unless you then choose to override that).

 

[SeToY]

so the OS/browser would generally be responsible for filtering to only show allowed file types (unless you then choose to override that).

Or unless you drag & drop onto the editor - which doesn't open an OpenFileDialog

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.8).

Change log:

Echo a list of allowed extensions back in the error message given when a file that does not have an allowed extension is uploaded.

There may be a delay before changes are rolled out to the XenForo Community.