Fixed Brand fa icon in bb code manager

[kick]

When a branded icon for bbcode is indicated, this icon is not visible in the control panel, but it is displayed in the user part

Admin bb code button manager:

icon: fab fa-html5

 

[Kier]

Looks like we hard-code the fa- in \XF\Data\Editor->getCustomBbCodeButtons() so now I have to work out why it works on the front end at all...

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.6).

Change log:

We need to detect if an icon defined as fa includes an `fa` prefix, such as `fab` etc., and if it already includes one, don't prepend our own.

Any changes made as a result of this issue being resolved may not be rolled out here until later.