Fixed [1.3.1] User Change Logs - Only 4 pages of results

[soloarquitectura]

Days ago, I have set:
User Change Log Length (Days) = 7

5 days ago, I have changed a lot of user states.

Today, when I enter in User Change Logs, I see only 4 pages of results (Page 4 of 4, http://www.mysite.com/myforum/admin.php?logs/user-change-log&page=4).

But changes are effectively logged.
I can access them changing the URL:
http://www.mysite.com/myforum/admin.php?logs/user-change-log&page=5
to
http://www.mysite.com/myforum/admin.php?logs/user-change-log&page=10

 

[Chris D]

Same thing is happening to me on 1.3.1.



That is being counted as 2 changes. But there would be a page break after another 11 individual changes were logged.

It seems like the fetch query returns 20 (per page) rows, but the count does not count the number of rows, it instead counts the number of distinct changes for each user at the specific time, e.g. it counts the groups of changes. This throws off the page nav so it is calculated incorrectly.

 

[Mike]

Fixed now. There was some mixed logic here. Getting the logs gets a total number of edits, but then groups them together logically. The count was attempting to group them logically (though there was a bug there as well). I've now changed the count to not do the grouping to deal with this issue. There is now a count method that does the grouping, though I don't think it will actually be used (I'm not sure what context would need it).