This does not allow to create add-ons which can be installed at 1.1 with TMS and also at 1.2 with integrated template system. This is very inconvenient and can easily be solved with a simple change of the XML parents tag used by 1.2 integrated template system, before too many add-ons are released for 1.2.
-
This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.
Fixed [1.2-beta1] Colliding XML parents tags with TMS
- Thread starter HWS
- Start date
This does not allow to create add-ons which can be installed at 1.1 with TMS and also at 1.2 with integrated template system. This is very inconvenient and can easily be solved with a simple change of the XML parents tag used by 1.2 integrated template system, before too many add-ons are released for 1.2.
It would be MUCH easier if XF changes the tag BEFORE to many XML files using its new syntax are out there. @Mike please rethink this decision.
It is also a polite and not unusual action by developers to not reuse tags already used by other developers.
Simply because there are really many XML files with TMS syntax out there. And, most important, because of the huge amount of time and ressources potentially saved for the support team of XF and most add-on creators.
And -no offense @King Kovifor - if you never used TMS neither in your forum nor in your add-ons you don't know how important this small change would be.
Let's add that Guiltar was there when XenForo had problems and when many have left. He created, alone & for free, a tool that became a reference and certainly has drained some traffic here.
Let's also add this addon has been used for more than 1 year here, so I really don't see how a developer could be retroactively blamed for a syntax that didn't exist before and why users should suffer of such a decision.
I was really happy to learn than XenForo developers had the idea to create a template modification system "before" TMS existed, even if I still don't see why it was more important to mention this than to have the courtesy to mention the name of the addon developer instead of only the name of his addon. Of course many will tell me it's a detail, sorry but I don't think so. May be a cultural difference then, who knows.
When a potential customer arrives here and asks for a discount if he translates XenForo, he's been replied that the product is a bargain (which is true), that the community is really dynamic and contributes a lot. You can't smile at customers saying "oh look at our community of developers how dynamic it is" and act like this. It's rude and, even more serious, it is technically a problem to maintain the addon compatibility between XenForo addon versions. And why is this technically a problem? Only for a xml syntax! Come on, why was it so important to use exactly the same syntax?
Now I've almost no illusion that this thread will change anything, but there's a problem here.
You seem to be implying that Mike deliberately set out to clash with a highly respected add-on. Have you not considered that perhaps @Mike just built the feature he wanted to build with the syntax and other naming conventions that is most consistent with the rest of the software?
It probably didn't occur to him that he should pull someone else's code apart before he built an important feature for his software.
Why should it?
Calling it a bug is far fetched. This is a suggestion, at best, and ultimately that the add-on developer should resolve. If there's still a place for TMS within XenForo then I'm certain @guiltar would be more than happy to adapt to the core software. That's what skilled add-on developers do.
But doing so will BREAK many add-ons which maybe will never be updated for 1.2, but can be used perfectly for 1.1. And it will create confusion and a high amount of support cases for sure.
What WE should have in mind at first place is the customer using XF. The most compatible and useful solution should be done to make it as easy as possible for the customer (who mostly doesn't know anything about XML) to use his Xenforo software. Even if a "general rule" will be broken.
However, this generally emphasizes that, as add-on devs, it's important to prefix things whenever possible, particularly when integrating deeply into the core. This probably something that we haven't made obvious enough until now (with this really only being the second opportunity for it really to rear its head).
Add-ons for 1.2 that use the built in modification system will need to be re-exported in beta 2 to get the updated XML name.
The TMS parent is now tms_mods. Addon devs just have to reexport the addons with new TMS.
Users, please test new version from github
It should be compatible with both 1.1 and 1.2.
Also I will write the importer TMS->Core.
But core does't support style modifications.
So maybe TMS will be extension of the core system for style mods.
Last edited: