Warning Improvements by Xon 2.11.5

• Fix 'attempted to read property "user_id" on null' when issuing a warning.
  • Occurs when "Warning Acknowledgments" add-on is not installed

• Only show previous warnings if a user can see them
• Add missing permission check for if a report can be resolved when editing a warning
• Fix that "resolve report" checkbox could be shown to users who can't resolve reports when editing warnings

• Improve UX around editing a warning when is Warning Acknowledgements enabled

• Fix that editing a warning's points would not change when the next-page load checks to expire just expired warnings.
• Fix edit points to zero + expiring a warning did not behave as expected

• Reduce queries when viewing a warning
• When editing, strip http://https:// out of links which had replacables in Warning Achnologement user notes

• If installed, require Report Improvements v2.10.1+
• XF2.2.6 compatibility update; fix per-warning "Allow editable warning title when giving warning" option disappearing
• Allow editing virtually all details for a warning, supports Report Improvements and Warning Acknowledgements.
• Allow sending an alert to the warned user on editing or deleting warnings, with an optional reason

• Fix silly bug where non-expiring warnings/bans where ignored when considering the next expiry time.

• Improve robustness of expiring warnings/bans/etc on the next page visit after they have expired.
  • Fix edge case where rebuild pending expiry time-stamp was not triggered as expected
  • On rebuild user caches, also rebuild pending expiry time-stamp

Older versions (XF1?) may have caused an expiry date of 4294967295 instead of 0 for non-expiring. It is recommended to review these warnings and manually expiring them;

SQL:

select * 
from xf_warning
where expiry_date = 4294967295 AND is_expired = 0

After this rebuilding user via tools => rebuild users, or via CLI php cmd.php xf-rebuild:users will recompute the next pending expiry for all users

• Hook up warning criteria take #2
• Simplify phrase sv_please_enter_note_with_at_least_x_characters
• When issuing a warning; add "required" flag to user notes if configured

• Minor code cleanup
• Actually implement warning criteria. Broken since initial v2.0.0 release