GoodForNothing Notification 1.0.6 Update 3

[dieketzer]

installed and seems to be working as expected. no errors, etc.
my only suggestion would be some option to leave a fake alert open for admin to make it easier to style, position etc.

 

[Skylined]

Create a test forum and change the display time to whatever you want.

 

[Pierre Boulanger]

A sort question please

How can I change the whit backround color just to improve the visibility?

 

[Mr. Goodie2Shoes]

How can I change the whit backround color just to improve the visibility?

AdminCP -> Appearance -> Style Properties -> GoodForNothing Notification -> Notification Item Content -> Background (color)

 

[Pierre Boulanger]

AdminCP -> Appearance -> Style Properties -> GoodForNothing Notification -> Notification Item Content -> Background (color)

Perfection!

 

[TheBigK]

Umm, maybe a silly question: But does the JS used in this addon run only for logged-in users? I don't want to feed Google Bots with extra JS on every page.

 

[Mr. Goodie2Shoes]

But does the JS used in this addon run only for logged-in users?

ahhh... forgot to add the conditional to only add the required js when the user is logged in

 

[TheBigK]

ahhh... forgot to add the conditional to only add the required js when the user is logged in

Okay, gotta load it up on our site once this one gets fixed. Should save some extra computation for every CPU.

 

[Mr. Goodie2Shoes]

Mr. Goodie2Shoes updated GoodForNothing Notification with a new update entry:

Added condional to only add the required externals if the user is logged in...

Added conditional so that the required externals are only added when the user is logged in.

Also pushed the add-on to stable channel.

Read the rest of this update entry...

 

[ARSamo]

I want the whole notification appeared at right side instead of left.. what setting required, please?

 

[Mr. Goodie2Shoes]

I want the whole notification appeared at right side instead of left.. what setting required, please?

Go to: AdminCP -> Appearance -> Templates -> gfnnotify_item.css (edit the template)
from the #GFNNotification block,
change

left: 0;

to

right: 10px;

 

[ARSamo]

Go to: AdminCP -> Appearance -> Templates -> gfnnotify_item.css (edit the template)
from the #GFNNotification block,
change

left: 0;

to

right: 10px;

works perfectly... Thanks

 

[Mr. Goodie2Shoes]

Mr. Goodie2Shoes updated GoodForNothing Notification with a new update entry:

Added user preference, misc improvements...

It has been a long time since I updated this add-on. And here's a new feature that was requested: Allow users to select if they want to see popups or not:
View attachment 91664
P.S: This is enabled by default.

Read the rest of this update entry...

 

[JordanH]

I get this:
Fatal error: Class 'GFNCore_Installer_Controller_Install' not found in /home/gamerebels/public_html/library/GFNCore/Installer/Abstract.php on line 59

 

[Mr. Goodie2Shoes]

I get this:
Fatal error: Class 'GFNCore_Installer_Controller_Install' not found in /home/gamerebels/public_html/library/GFNCore/Installer/Abstract.php on line 59

Ah... An issue with the packager... Download and extract the previous version and the overwrite the files from the latest version... I'll fix the package once I get back.

 

[Mr. Goodie2Shoes]

Mr. Goodie2Shoes updated GoodForNothing Notification with a new update entry:

Fixed an issue with the packager

You might notice if you look into the code that I use a custom 'builder' to package my add-ons. This issue recently occurred so my guess is a friend who recently visited me might've changed part of the code to troll me.

Anyways, the missing files have been added. Enjoy!

Read the rest of this update entry...

 

[Stuart Wright]

This is a really neat addon, thank you.
Because we have a white box on a white background, it looks a little confusing.
It would be improved enormously in my opinion, with a faint border.
1px solid @faintText maybe.
And maybe a box-shadow to bring it out of the page a bit.
However if I use the style properties to put a border on the 'notification item', the border doesn't collapse during the animation. If I put a border on the 'notification content' the avatar is larger and exists above the border.
What's the best way to achieve the desired result please?

[Edit : having this installed screws up the styling on some pages. Is there something in the css or the javascript which could be breaking the css on some pages? Had to disable the addon for now.]

 

[Mr. Goodie2Shoes]

having this installed screws up the styling on some pages.

Can you take a screenshot?

What's the best way to achieve the desired result please?

You'll have to do a little template edit: Open the template gfnnotify_item.css, search for the block

.notificationItem .userAvatar

replace it with:

.notificationItem .userAvatar {
   height: {xen:calc "@notificationAvatarSize - 2"}px;
   display: block;
   position: absolute;
   top: 1px;
   left: 1px;
   z-index: 1000;
}

and then add the border to the Notification Item Content property, and the avatar should be inside the border.

 

[Stuart Wright]

Thank you for the css tip.

Can you take a screenshot?

When the addon is disabled, the gfnnotify css is not included in the css.php call and it works fine:

https://xf.avforums.com/sandbox/css...allery_tab_links&style=2&dir=LTR&d=1418556731

When the addon is enabled, this is the css.php call:

https://xf.avforums.com/sandbox/css...allery_tab_links&style=2&dir=LTR&d=1418556731

and this causes a 502 Bad Gateway error. So none of the css in that call is loaded and the page looks very broken.

 

[Mr. Goodie2Shoes]

@Stuart Wright I am not sure why the css will return a bad gateway error... My only guess is because the the css 'get' parameter is too long, so php-fpm is dropping the connection?