Lack of interest xf-addon:install-step: log the reason for conflict

[DragonByte Tech]

After I re-ran my installStep1 I had about 10 __conflict tables. What I didn't have, was any information indicating why these tables were conflicting. I had to manually export them to compare them using Beyond Compare.

After about 30 minutes I discovered you can't directly add floats to setDefault, due to strval(). Simple enough fix

It would be very useful if running xf-addon:install-step while in development mode also logged the reason for the conflict. It should be as simple as running two array_diff calls and merging them, then var_export($merge, true) that onto the end of the already logged error message.


Fillip

 

[Xon]

I've ended up writing an addOrChangeColumn helper for a bunch of my installers since it is nearly always valid to run the change if the column exist (ie XF1 =>XF2 upgrades). As other wise you get __conflicts the upgrade process silently fails.