Fixed XenForo_Model_Thread::FETCH_AVATAR bug

[xfrocks]

This is a minor bug.

File: xenforo/library/XenForo/Model/Thread.php
Line: 131

else if ($fetchOptions['join'] & self::FETCH_AVATAR)
{
$selectFields .= ',
user.avatar_date, user.gravatar';
$joinTables .= '
LEFT JOIN xf_user AS user ON
(user.user_id = thread.user_id)';
}

The $selectFields should include user gender to display the no-avatar image correctly. So, that code snippet should be

else if ($fetchOptions['join'] & self::FETCH_AVATAR)
{
$selectFields .= ',
user.gender, user.avatar_date, user.gravatar';
$joinTables .= '
LEFT JOIN xf_user AS user ON
(user.user_id = thread.user_id)';
}

 

[erich37]

for reference:

http://xenforo.com/community/threads/bd-widget-framework.28014/page-25#post-411195

 

[Jake Bunce]

Yes indeed.

At first I thought... wait a minute, the thread list doesn't have this problem. But I see that the thread list uses FETCH_USER not FETCH_AVATAR.

 

[Mike]

Good catch, fixed.