Fixed Wrong language does get overwritten

[Kirby]

Affected version

2.0.10

Steps to reproduce

1. Create a new language "German" with locale de-DE
2. Change/"Translate" a few phrases in that language for Add-on XenForo
3. Export the translation
4. Import the generated XML and select to overwrite language "English"

Expected Result
XenForo does not automatically overwrite the language but does generate a warning that the locale does not match asking if the users wants to proceed anyway

Actual Result
XenForo does overwrite the language resulting in a broken/mixed language

I know that this is kind of an ID-10-T error, but it would be nice if XenForo did prevent this

 

[S Thomas]

XenForo does overwrite the language resulting in a broken/mixed language

Doesn't that happen because the Master language is English and as such non-translated phrases still are, well, English?

 

[Mike]

This isn't really a bug, but we have addressed this in 2.1 with some other changes. By default, it won't let you overwrite a language if the language code/locale differs. We do the same thing with style titles too. You have the option to bypass these errors and continue with the import anyway.

(There are some other details on the changes here: https://xenforo.com/community/threa...forum_view-php-on-line-22.157957/post-1307492)