How did you fix it? With this code?
if(is_null($users)){
$users = 0;
}public function actionIndex(ParameterBag $params)
{
$reply = parent::actionIndex($params);
if (!($reply instanceof \XF\Mvc\Reply\View))
{
return $reply;
}
// your code here
$reply->setParams([
'users' => $users,
'userswhoread' => $userswhoread
]);
return $reply;
}Yes, but during the update, you did not drop or rename the old table, so it will now remain in the database as garbage. Also, during uninstalling the add-on, you drop the table with the old name and not the one with the new one.
I updated the resource a few moments ago. I've forgotten to see this. I was thinking of variable $users if null. And no, it is not controller for replyin to the thread xD
. It's thread view where i just add 2 widgets to display who currently is viewing a topic and who has read that topic .
<a href="{{link('members')}}{{$members.username}}.{{$members.user_id}}" class="username" dir="auto" itemprop="name" data-user-id="{{$members.user_id}}" data-xf-init="member-tooltip"><xf:if is="$members.username_css"><span style="{{$members.username_css}}">{{$members.username}}<xf:else/>{{$members.username}}</span></xf:if></a><xf:username user="$members" rich="true" />{{link('members')}}{{$members.username}}.{{$members.user_id}. You had to do this: {{ link('members', $members) }}.There is nothing wrong with displaying style as described in resource. It's based on user group style.
Nothing wrong? And the fact that my styles are not applied in these blocks? This is just out of the box. And even all styles will not work out of the box, for example, classes for banned users, staff, administrators and moderators are not applied.
xf:username so that there are no questions from addon users. And the implementation itself, again, will not allow other add-ons to make any changes to the behavior of the username link.I can't reproduce that. These two blocks are custom created by my addon. Which will display color of user groups.
I am not asking you to reproduce it, I am saying that it is not necessary to do so. You've hard-coded the username display so that no styles other than group styles can be applied to them, and any changes to username display made by other add-ons simply won't work here.
Will work if you extend the addon ofc.
Are you joking? I'm showing you that my custom style doesn't apply here.
xf:username:
By default XenForo has not implemented custom username styling other than by user group. My main idea was to do user color based on his own user group.
You are not right. Out of the box there is also styling for banned users and it is possible to add styles for staff, admins and moderators.
Easiest for widget who is currently viewing a thread can't be. Because they are getting from SessionActivity and in array username_css is imported from his own user group. If you have in table custom column that allow custom styling you can replace with yours.
I know, but <xf:username won't render the user color based on his user group. That's why i added 2 entities and make relationships with UserGroups so i later can access via magic method when getting users and usergroups from Thread entity.I just leave it here.
Try adding
rich ="true". This is not mentioned in the documentation, but without it, the styles will not be applied.Perhaps that <xf:username will render all informations with <a> and closin tag i don't think it's possible without breaking the display of user group styling. If this is case, you can edit the template and make to fit your needs.
Nothing should break if everything is correct.
