• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed When moving threads, $thread in sendModeratorActionAlert() still holds the old node id

rellect

Well-known member
#1
The function XenForo_Model_InlineMod_Thread::moveThreads process each thread, and sends an alert to the user (if needed).
One of the parameters of the alert function is $thread.
What I've noticed is that $thread is being transferred to XenForo_Model_Thread::sendModeratorActionAlert when it still holds its old node id.
I think it should hold the new one, since the thread being saved (`$dw->save()`) and only then the alert being sent. So at this point the thread already has been moved, and the node id should be updated.
 

Mike

XenForo developer
Staff member
#2
Arguably ambiguous as to what's expected, but I think it's reasonable to change the node_id when moving a thread (makes it easier to log the target forum, which is what I assume you're doing).