D
Deleted member 232995
Guest
Why is "{username}" not enough?
adnanbcn
Active member
{username} = user who upload. But i mean {currentusername}, any login user.
D
Deleted member 232995
Guest
Of course this is feasible! The only problem is that this is a variable that changes with every view of another user. What makes the caching (which could be used) obsolete.
But the sense of this is clear to me and I think it makes sense. Therefore I will implement. But that there is then no caching must be clear.
But the sense of this is clear to me and I think it makes sense. Therefore I will implement. But that there is then no caching must be clear.
adnanbcn
Active member
Thank you very much, I have a small forum of about 150 users where I have technical drawings only for registered users. The forum only allows new users with an invitation because I want to avoid leaks of these technical drawings. One watermark per user would help me protect my work.
X0815\Watermarker\Marker::__construct()
PHP:
@ini_set('gd.jpeg_ignore_warning', 1);
$this->attachment = $attachment;
$this->attachmentData = $attachment->Data;
$this->attachRepo = $this->getAttachmentRepo();
$this->_options = \XF::options();
$this->font = \XF::getRootDirectory() . $this->font;
if(!empty($this->_options['watermarkerType']['font_path']))
{
$this->font = \XF::getRootDirectory() . $this->_options['watermarkerType']['font_path'];
}
if(!$this->_options['watermarkerType']['enabled_image'] && !$this->_options['watermarkerType']['enabled_text'])
{
return false;
}
$this->outputImage = $this->attachmentData->getAbstractedWatermarkerDataPath();
if(\XF::fs()->has($this->outputImage))
{
$simpleCache = \XF::app()->simpleCache();
$lastSettingsChange = $simpleCache->getValue('X0815\Watermarker', 'lastSettingsChange');
$fileAge = \XF::fs()->getTimestamp($this->outputImage);
if(
\XF::options()->watermarkerCacheRefresh != 0 &&
($fileAge >= $lastSettingsChange) &&
($fileAge > \XF::$time - (\XF::options()->watermarkerCacheRefresh * 86400))
)
{
$this->status = true;
}
}
$tempFile = \XF\Util\File::getTempFile();
$stream = \XF::fs()->readStream($this->attachmentData->getAbstractedDataPath());
@file_put_contents($tempFile, $stream, FILE_APPEND | LOCK_EX);
$this->inputImage = $tempFile;
if($this->status)
{
return false;
}I am not 100% sure, but I think this might cause unnecessary overhead:
if
$this->status is true, the watermarker image does exist and is valid - there is no need to prepare processing.Hence the input file is not required and the copy to a temporary file seems useless.
Probably better approach:
PHP:
if(!$this->_options['watermarkerType']['enabled_image'] && !$this->_options['watermarkerType']['enabled_text'])
{
return false;
}
$this->outputImage = $this->attachmentData->getAbstractedWatermarkerDataPath();
if (\XF::fs()->has($this->outputImage))
{
$simpleCache = \XF::app()->simpleCache();
$lastSettingsChange = $simpleCache->getValue('X0815\Watermarker', 'lastSettingsChange');
$fileAge = \XF::fs()->getTimestamp($this->outputImage);
if(
\XF::options()->watermarkerCacheRefresh != 0 &&
($fileAge >= $lastSettingsChange) &&
($fileAge > \XF::$time - (\XF::options()->watermarkerCacheRefresh * 86400))
)
{
$this->status = true;
}
}
if ($this->status)
{
return false;
}
@ini_set('gd.jpeg_ignore_warning', 1);
$this->attachment = $attachment;
$this->attachmentData = $attachment->Data;
$this->attachRepo = $this->getAttachmentRepo();
$this->_options = \XF::options();
$this->font = \XF::getRootDirectory() . $this->font;
if(!empty($this->_options['watermarkerType']['font_path']))
{
$this->font = \XF::getRootDirectory() . $this->_options['watermarkerType']['font_path'];
}
$this->inputImage = \XF:\Util\File::copyAbstractedPathToTempFile($this->attachmentData->getAbstractedDataPath());Another possible problem:
It seems like
X0815\Watermarker\Cron::dailyClean() (which calls \X0815\Watermarker\Marker\Water::removeOldWatermarksImages()) directly performs file operations on internal_data - this violates resource standards rule # 29.
D
Deleted member 232995
Guest
I just changed this completely and adjusted it accordingly. Thanks
Thank you this is known to me and would be changed by the new wish anyway! Here I will improve! THANKS
D
Deleted member 232995
Guest
0815 updated Watermarker with a new update entry:
1.1.0 Beta 1
Read the rest of this update entry...
1.1.0 Beta 1
Read the rest of this update entry...
D
Deleted member 232995
Guest
0815 updated Watermarker with a new update entry:
1.1.0 Beta 1 Patch1
Read the rest of this update entry...
1.1.0 Beta 1 Patch1
Read the rest of this update entry...
D
Deleted member 232995
Guest
adnanbcn
Active member
New version working without error.
I try to use > © {currentYear} {username} {visitorUsername} but not work (may it,s my chrome cache).
D
Deleted member 232995
Guest
adnanbcn
Active member
I check again and again, but I think something is wrong. If user_1 go to a post see the watermarker "user_1" but if the user_2 go to same post also see "user_1" watermarker. And if the "user_2" go to the other post before then "user_1" or any user, everybody see watermarker "user_2".
D
Deleted member 232995
Guest
OK thanks for the detailed report! I will try to reproduce it here tomorrow.
adnanbcn
Active member
Thanks!
D
Deleted member 232995
Guest
What is the status here? Have other problem with the new version?
Hi, thank you for updating the add-on's features.
The options look perfect and as requested.
However, I can get a watermark to show up while using the "Watermark normal for all" setting, but whenever I attempt to replicate the same options on the different user groups the watermarks are not showing up.
I will continue testing, but so far I cannot work out what the add-on (or myself) is doing wrong...
The options look perfect and as requested.
However, I can get a watermark to show up while using the "Watermark normal for all" setting, but whenever I attempt to replicate the same options on the different user groups the watermarks are not showing up.
I will continue testing, but so far I cannot work out what the add-on (or myself) is doing wrong...
