1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Warnings - conversation sending (lack of error handling)

Discussion in 'Resolved Bug Reports' started by Xon, Jun 15, 2015.

  1. Xon

    Xon Well-Known Member

    When creating a warning, the option to send a conversation doesn't check if the title is set. If it isn't set (but the message and checkbox are), the warning is issued and the conversation silently fails to be created.

    Code:
    			$conversationInput = $this->_input->filter(array(
    				'conversation_title' => XenForo_Input::STRING,
    				'conversation_message' => XenForo_Input::STRING,
    				'conversation_locked' => XenForo_Input::UINT,
    				'open_invite' => XenForo_Input::UINT,
    			));
    
    			if ($conversationInput['conversation_title'] && $conversationInput['conversation_message'])
    			{
    ...
    			}
    
     
    batpool52! likes this.
  2. Chris D

    Chris D XenForo Developer Staff Member

    Thanks, this is sorted now.

    We give a specific error in the event that we have a title and no message or have a message and no title.
     
    Xon likes this.

Share This Page