Duplicate Video upload fails due to non-whitelisted ftyp

[Kirby]

Affected version

2.2.8 PL 1

Apparently https://xenforo.com/community/threa...s-not-a-video-as-expected.178773/post-1546143 was missed so I am opening a new bug report.

Currently videos with typ 3gp5 (which is used by Samsung Galaxy S21 Ultra at least) cannot be uploaded as this ftyp is missing in the whitelist.
As diagnosing such issues is kinda complicated (we have to ask the users for the original files to inspect the header) it might make sense to at least add some kind of logging if an unknown ftype is discovered.

Ideally, it should be possible to configure additional types (via config.php) so it is not necessary to patch (or extend the class and overwrite the whole method) just to add an new type.

 

[hIBEES]

I have a Galaxy S20 FE and editing a video and then trying to upload it. I get that very same error.

 

[mattrogowski]

I've reported this too (https://xenforo.com/community/threads/3gp-encoded-mp4-videos-not-accepted.206305/) and have been other reports before me (oh just seen this is an older thread and linked in the reply to mine).

You're welcome to use the attached hacky workaround addon I implemented for this. It re-defines the entire function that checks the video and adds in a few characters to allow these videos. It's unlikely this file will change between patch version upgrades, but it does log an error the error log if you upgrade and haven't upgraded the addon, just to note that the code may be mismatched. But it will solve this problem for you.

 

[Imgbi]

I've reported this too (https://xenforo.com/community/threads/3gp-encoded-mp4-videos-not-accepted.206305/) and have been other reports before me (oh just seen this is an older thread and linked in the reply to mine).

You're welcome to use the attached hacky workaround addon I implemented for this. It re-defines the entire function that checks the video and adds in a few characters to allow these videos. It's unlikely this file will change between patch version upgrades, but it does log an error the error log if you upgrade and haven't upgraded the addon, just to note that the code may be mismatched. But it will solve this problem for you.

Installed your addon, still having the issue.
The video I wanted to upload is less that 2MB, downloaded from Twitter.

 

[mattrogowski]

Then it's likely a different issue. The file size isn't relevant, it's the internal encoding. Without the video it's impossible to tell.

 

[Imgbi]

Then it's likely a different issue. The file size isn't relevant, it's the internal encoding. Without the video it's impossible to tell.

Permission to send the video via private message?

 

[mattrogowski]

Sure

 

[mattrogowski]

Yeah, is a different issue... first few bytes of the video are ftypiso5 iso6, XF's video encoding regex includes iso6 but it has to come immediately after ftyp which it doesn't here.

I can't prep a new version of this addon right now, but if you edit src/addons/ThemeHouse/Allow3GpVideos/XF/Http/Upload.php, line 37, change:

'ndxm', 'ndxp', 'ndxs', 'xavc', '3gp'

to:

'ndxm', 'ndxp', 'ndxs', 'xavc', '3gp', 'iso5'

it will accept it.

 

[Imgbi]

Working fine.
Thanks a lot!

 

[Chris D]

A duplicate of this bug has been fixed for 2.2.12. We've also pushed the ftyp array into a method called getSupportedMp4Ftypes so add-ons can extend it more easily.

 

[mattrogowski]

We've also pushed the ftyp array into a method called getSupportedMp4Ftypes so add-ons can extend it more easily.

That's a welcome change, thank you.