User Mentions Improvements by Xon 2.10.2

[Xon]

Have you tried updating Standard Library addon, and how the release notes mention it is required ?

 

[MentaL]

Trying to install X on my main board and I get

[LIST]
[*]rrorException: Fatal Error: Declaration of SV\UserMentionsImprovements\XF\Admin\Controller\UserGroup::userGroupSaveProcess(XF\Entity\UserGroup $userGroup) must be compatible with apathy\StyleSuite\XF\Admin\Controller\UserGroup::userGroupSaveProcess(XF\Entity\UserGroup $userGroup): XF\Mvc\FormAction
[*]src/addons/SV/UserMentionsImprovements/XF/Admin/Controller/UserGroup.php:10
[*]Generated by: x
[*]Sep 19, 2024 at 7:10 PM
[/LIST]
[HEADING=2]Stack trace[/HEADING]
#0 [internal function]: XF::handleFatalError()
#1 {main}
[HEADING=2]Request state[/HEADING]
array(4) {
  ["url"] => string(23) "/admin.php?user-groups/"
  ["referrer"] => string(67) "https://forum.x.com/admin.php?options/groups/ap_style_suite/"
  ["_GET"] => array(1) {
    ["user-groups/"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }

 

[Xon]

apathy\StyleSuite (or some other add-on) is incorrectly adding a return type that doesn't exist in stock XF.

Newer phpstorm versions are better at not suggesting adding a return type to functions which are missing it when they override an existing method

 

[alfaNova]

Xon updated User Mentions Improvements by Xon with a new update entry:

2.10.1 - XenForo 2.3 support



Read the rest of this update entry...

Is the 2.10.1 version of the addon compatible with Xenforo 2.2.+?

 

[ENF]

Is the 2.10.1 version of the addon compatible with Xenforo 2.2.+?

Yes. (in case that's not clear, this update is just adding 2.3 support, not removing earlier versions from 2.2, etc.)

 

[association]

Hi @Xon ,
Thanks for this nice addition.

I wanted to ask you: I see that if I allow users to autocomplete the group name [so that the name pops up as they start typing], it necessarily also allows users to view the group members.
Is there a way to split the permissions? That is, allow a user who types a group name to see the group name immediately before they finish typing it [similar to a normal mention of other users], and yet prevent users from viewing who the members of each group are.

I would really appreciate your answer,
Thank you very much.

 

[Xon]

There is the [UMI] View mentionable user group members permission which is separate from [UMI] Mention user groups permission.

 

[association]

There is the [UMI] View mentionable user group members permission which is separate from [UMI] Mention user groups permission.

If the permission
[UMI] View mentionable user group members
is not enabled
even if the permission
[UMI] Mention user groups
is enabled
no autocomplet.
That's my problem

 

[Xon]

I should have a fix for that overly strict permission check by Monday.

 

[frm]

This fits but doesn't quite fit User Mention Improvements in the way it doesn't improve Mentions, but the display of mentions in posts and elsewhere.

If you take notice of @frm, you will see data-user-id="187211" in the tag for @frm. This LESS (in extra.less is the only way to change the color of @frm when tagged in a post, else it uses the default blue (on XF, default on other forums).

I believe this could be a UI improvement for tagging members so that members could share the tag color of the group they're in or be individually assigned a new color on a member-by-member basis.

[data-user-id="1"],[data-user-id="25"],[data-user-id="163"]{
    .m-colorScheme(light,
        {
            color: green;
            -webkit-text-fill-color: green;
        }
    );
    .m-colorScheme(dark,
        {
            color: red;
            -webkit-text-fill-color: red;
        }
    );
    font-weight: bold;
}

Would this be something that you would consider implementing?

Edit: You may only want to apply it to bbWrapper as that's where someone would be mentioned, otherwise the code above would change the postbit too*

 

[Xon]

Xon updated User Mentions Improvements by Xon with a new update entry:

2.10.2 - Bugfix update

• Fix mentioning a group when [UMI]View mentionable user group members permission isn't granted but [UMI] Mention user groups permission is, didn't work.

Read the rest of this update entry...

 

[association]

Xon updated User Mentions Improvements by Xon with a new update entry:

Thank you very much, great work!