XF 2.3 URL fields in Resource Manager

Robert9

Well-known member
Licensed customer
Shouldn't the external URL fields in Resource Manager have a maxLength defined?

For example, xf_rm_resource.external_url is limited by the database column, but the corresponding entity field does not appear to define a maxLength.

Wouldn't it make sense to add a matching maxLength to external_url, external_purchase_url, and alt_support_url so that overly long URLs are rejected during entity validation instead of causing a database error?
 
By the way, there are validation messages such as “Please enter a title”, where everyone immediately knows which field is meant.

But there are also messages such as “Please enter a value using x characters or fewer” without identifying the affected field.

Depending on the size of the form, this can be quite annoying because you may have no idea which field actually caused the error.

Wouldn't it make sense to make these validation messages consistent and always identify the field they refer to?
 
BTW, while we're on the subject of identifiers:

When developing an add-on, I sometimes make mistakes in templates, and an add-on can easily contain dozens of templates. If a build then fails because of a template error, I have to search for the template that caused it.

XenForo should know which template it is processing when the error occurs, shouldn't it?

If so, could the template name be included in the error message? That could save developers quite a bit of time when tracking down build errors.
 
Back
Top Bottom