Fixed "Upload a File" button in iOS9

[refael]

When editor is in focus and keyboard is visible, occasionally I cannot click on "Upload a File" button.
This only started after upgrading to ios 9.0.2.

 

[EQnoble]

When you say you cannot click, do you mean it is not there, greyed out (unavailable),button as normal but can't be clicked etc etc?

Just on a hunch and pending your answer to the question above I would suggest switching to the default xf style and see if you can replicate it if you have not already.

 

[refael]

It looks normal and just can't click on it.

 

[Chris D]

Does this happen here? I can't reproduce it at the moment.

 

[refael]

Does this happen here? I can't reproduce it at the moment.

Yes I can reproduce it here. I think it may be related to how quickly you tap.
I noticed that when I quickly tap, the button will be pressed. But if I tap and hold for 400ms~ before I lift my finger, it won't work.

 

[Chris D]

Do you see the blue caret flashing when it fails to action? I'm wondering if it's related to the editor being focused.

 

[refael]

Do you see the blue caret flashing when it fails to action? I'm wondering if it's related to the editor being focused.

If I keep holding it starts to select text on the page.

 

[Marvin Herbold]

Safari on iOS blows - it is quite buggy. The same thing happens in Wordpress when you are using certain themes - the "Read More" button no longer functions properly. You tap on it and nothing happens. We have found that certain css styles break anchor tags on iOS Safari. Stupid, I know. To get the "Read More" button on our Wordpress working again on iOS we've had to disable some shadow css styling. Something similar is probably happening here.

 

[Chris D]

It's actually not something we've been able to reproduce at the moment.

@rellect can you provide any more detailed reproduction steps? Which iOS version? Which device etc?

 

[Marvin Herbold]

It's probably the theme they are using that has some css styling on the button that breaks it for iOS.

 

[refael]

It's actually not something we've been able to reproduce at the moment.

@rellect can you provide any more detailed reproduction steps? Which iOS version? Which device etc?

I'm curretly on 9.2.0 (iphone 5) and the bug here is rarely happens now.

The steps are quite simple:
1. Create a new thread
2. Write something
3. While keyboard is still visible, click on Upload a File

This may require a physical device running ios9 to test on. But as I mentioned, after upgrading to 9.2 it's now rarely happens.

There is similar issue with the popup to upload files though. I usually cannot click on the 'close' button, I attached screenshots.

 

[Chris D]

I had only been testing it on the quick reply, to be honest.

Maybe that's why I couldn't reproduce it, I will take another look, thanks for the additional info

 

[Chris D]

I've still been unable to reproduce the originally reported issue, but we have made changes here specifically to fix the close button issue and I reckon this will generally help.

We now specifically blur the editor when the "Upload a File" button is clicked.

We'll roll this out here shortly if you'd like to test

Thanks.

 

[Chris D]

@rellect that should be rolled out here now

 

[refael]

@rellect that should be rolled out here now

Yea seems to be okay now