Fixed Upgrading from XF 1.5.24 to 2.3.5 still broken

[Sim]

Affected version

2.3.5

I've seen plenty of discussion about this and claims that it's been fixed - but I just tried a test upgrade from XF 1.5.24 to 2.3.5 and the upgrade process breaks - just like other reports that have apparently been fixed.

...
Running upgrade to 2.3.0 Alpha, step 7... done.
Running upgrade to 2.3.0 Alpha, step 8...
In AbstractStatement.php line 230:

  MySQL statement prepare error [1054]: Unknown column 'priority' in 'field list'


xf:upgrade [--skip-statistics]

Exception query:



  INSERT  INTO `xf_job` (`execute_class`, `execute_data`, `unique_key`, `manual_execute`, `trigger_date`, `priority`) VALUES (?, ?, ?, ?, ?, ?) ON DUPLICATE KEY UPDATE
                        execute_class = VALUES(execute_class),
                        execute_data = VALUES(execute_data),
                        manual_execute = VALUES(manual_execute),
                        trigger_date = VALUES(trigger_date),
                        last_run_date = NULL,
                        priority = VALUES(priority)

This was just a test on my dev server, but I'll have two XF 1.5.24 production sites I want to upgrade soon, so it would be nice to have an upgrade process that actually works instead of needing to do the upgrade in multiple parts.

Happy to help test fixes - I have a dev environment all ready to go.

 

[Wildcat Media]

Good to know as I have a major project doing the same upgrade from 1.5.24.

 

[Sim]

Good to know as I have a major project doing the same upgrade from 1.5.24.

FWIW, upgrading to 2.2.17 first and then to 2.3.5 will work - I just tested it. You can even go directly to PHP 8.3 using this method - the XF 2.2.17 upgrade script seems to work fine on PHP 8.3

I would still like to avoid having to do it in two steps though!

 

[Sim]

My testing (using fresh installs in each case):

• XenForo 2.2.17 to 2.3.5 upgrade works
• XenForo 2.1.15P1 to 2.3.5 upgrade works
• XenForo 2.0.13 to 2.3.5 upgrade works
• XenForo 1.5.24 to 2.2.17 to 2.3.5 upgrade works
• XenForo 1.5.24 to 2.3.5 (direct) upgrade does not work

 

[CedricV]

With all respect, but I don’t see the problem here. A two step upgrade is still considered very good, is it not?

Genuine question. No disrespect here.

 

[Sim]

The fact is - the upgrade process is broken. That's a bug.

Yes, there's a workaround, but it's still a bug in a supported version of the software.

 

[Wildcat Media]

With all respect, but I don’t see the problem here. A two step upgrade is still considered very good, is it not?

It's not good if we don't know about it; @Sim has done all the homework. If I'd tried this without knowing the process was broken, I'd be looking it up after an upgrade failed.

FWIW, upgrading to 2.2.17 first and then to 2.3.5 will work - I just tested it. You can even go directly to PHP 8.3 using this method - the XF 2.2.17 upgrade script seems to work fine on PHP 8.3

By the time I can set aside the hours I need to complete it, the bug might be fixed.

 

[Bionic Rooster]

My testing (using fresh installs in each case):

• XenForo 2.2.17 to 2.3.5 upgrade works
• XenForo 2.1.15P1 to 2.3.5 upgrade works
• XenForo 2.0.13 to 2.3.5 upgrade works
• XenForo 1.5.24 to 2.2.17 to 2.3.5 upgrade works
• XenForo 1.5.24 to 2.3.5 (direct) upgrade does not work

Thanks for extensive testing.

The fact is - the upgrade process is broken. That's a bug.

Yes, there's a workaround, but it's still a bug in a supported version of the software.

Your testing does not show a bug upgrading to 2.3.5, what it does show to me is that the sequential upgrades from 1.5.24to 2.2.17 sets up different changes to the code that allows for working upgrade to 2.3.5. Remember that with each upgrade from minor to major latest release had major changes in the code so sequential upgrades are needed for each to comply with the next upgrade.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.6).

Change log:

Fix upgrades from XF 1 not having the correct xf_job table schema changes applied

There may be a delay before changes are rolled out to the XenForo Community.